From owner-svn-src-all@freebsd.org Tue Dec 18 08:40:26 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 578A4134662D; Tue, 18 Dec 2018 08:40:26 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BC92786C27; Tue, 18 Dec 2018 08:40:25 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x442.google.com with SMTP id z5so14941286wrt.11; Tue, 18 Dec 2018 00:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=FQLdXy2J3+g2KGxNdljEdCLcHv8PjLzrfmEwNqsNlXg=; b=OFD8eq/YNziRQrbxwqOhURBi4bkOvbsbyyJWxsldJ5RC97wd0Di64oE4uXjVn9j41+ RCQPbodr0vm50qZ3rRTiVA0KbjRUNwPf6HXVDpwc9OW9MGprrOrF26qrZzu+1Al3td2K 5jxVTbk2SGuAsO0dMpPhSOIwL9Khvn5eYi7l5XcoxLypzVV0cWAKuOScPx0mz/Y8hnX3 3ePo9WC35J2bi3Lsv3Ar0VX6MCgk+ElVfc6FldksfghAQOaNbBvaUR+q0LTpXjcU8u5/ 5LFltgT6xz+VU/1nXwvUtw1nIPTElmqox63J6rJ6fLJun4Y2Rz51seUhm+MibwR5SoqS CSiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=FQLdXy2J3+g2KGxNdljEdCLcHv8PjLzrfmEwNqsNlXg=; b=GWBapXTzOLvLSDq0QZDFScVvc93bz+gJ3k4/Kw2IF8qQG+mCD6oAVw4GSX5pCy8t9G jFR2NtFpM9wxDd0m40lZ9AIvxvRl7g1SBgvRCBtQL0nsxtoOpOkttGjzt0mDn3nDQ/S+ ll/gkV2+XEbtWty0uucut2fk/VHkXA+TZQmNLDfM8VH99DxPGp7clc1tjzRlY85rMp89 MQu8PTKchp64FSHbJaYdA9BOdaLm55lHI+7MGf48FLKTp1h2lUhUAwXeM9nGaUrmVkZG kXhaLFnOrEsMYnK9frTxHyBQOotpOg0XjOpzH2N/sbp5oo76v3VncZJnDWx+i7rPFc9w 4KFg== X-Gm-Message-State: AA+aEWYAkYJA5fkz5PdLRAEeEFH+myOjmRKDmM5S1c9N1cV9y2FqAUgw v6c1IEg/SIeKgqW5xIzocapea55c X-Google-Smtp-Source: AFSGD/WgCvVqwwjZNewC5L4qZz5Of8XlRiX74iFP+GAjepCNies2G0k1YLd35JiMPIA19d9U3nvPiQ== X-Received: by 2002:adf:b608:: with SMTP id f8mr13083159wre.120.1545122424625; Tue, 18 Dec 2018 00:40:24 -0800 (PST) Received: from ernst.home (p5B02380D.dip0.t-ipconnect.de. [91.2.56.13]) by smtp.gmail.com with ESMTPSA id n82sm1222285wma.42.2018.12.18.00.40.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 00:40:23 -0800 (PST) Date: Tue, 18 Dec 2018 09:40:22 +0100 From: Gary Jennejohn To: Andrew Gallatin Cc: Bruce Evans , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Slava Shwartsman Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en Message-ID: <20181218094022.0deab2fa@ernst.home> In-Reply-To: References: <201812051420.wB5EKwxr099242@repo.freebsd.org> <9e09a2f8-d9fd-7fde-8e5a-b7c566cdb6a9@cs.duke.edu> <20181218033137.Q2217@besplex.bde.org> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BC92786C27 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 08:40:26 -0000 On Mon, 17 Dec 2018 14:50:04 -0500 Andrew Gallatin wrote: > On 12/17/18 2:08 PM, Bruce Evans wrote: [snip] > > iflib uses queuing techniques to significantly pessimize em NICs with 1 > > hardware queue. On fast machines, it attempts to do 1 context switch per > > This can happen even w/o contention when "abdicate" is enabled in mp > ring. I complained about this as well, and the default was changed in > mp ring to not always "abdicate" (eg, switch to the tq to handle the > packet). Abdication substantially pessimizes Netflix style web > uncontended workloads, but it generally helps small packet forwarding. > > It is interesting that you see the opposite. I should try benchmarking > with just a single ring. > Why are iflib and ifdi compiled into EVERY kernel with device ether and/or device pci when only a few NICs actually use iflib? This is really unnecessary bloat in an already bloated kernel. I use if_re which does not use iflib. I removed iflib and ifdi from /sys/conf/files and my network still works just fine. It seems to me like these iflib entries need finer-grained options, e.g. one of the NICs which use iflib is enabled, before pulling them into the kernel build. -- Gary Jennejohn