From owner-dev-commits-src-main@freebsd.org Wed Mar 10 11:57:46 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E6BC15AE4B8; Wed, 10 Mar 2021 11:57:46 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DwVvG27Hpz3CPp; Wed, 10 Mar 2021 11:57:46 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lj1-x235.google.com with SMTP id a17so25248419ljq.2; Wed, 10 Mar 2021 03:57:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RTLQArsi/Hl0m7yp8cFzanZ4mLDILxLOMNivZaabkZM=; b=qbRy7xBn6BgVKipWSJw0tWmkm+yRy+6EoftBU9z8Q1GIZ4JRo4AjIQPy4izArHouIz sGn5HZrJcr8kUlATlncnu5TNM9mWFYNJYgvneesOL5ygWXcbkGBZEtYlqNUwB3T0MOzl EKpcaFJEP4PPBkM8wzxONl2urzEvo6FxBT7Bf9zy9SWISEiPE6mqaL1Dfw5Qkzjdr7Kb 7opsdw+3ik+kkCia3765JgvSuwO23Zd8t5vVzZ9x541Ba9Wd+W31BLaGNjosw8rwLD1J /BGzkNeZGAPB1DWHWMDUKu/7ZOXogqn66EOXbTjO5PG8jk2VCq3NgSCwBpnJGu7HMGgO BbGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RTLQArsi/Hl0m7yp8cFzanZ4mLDILxLOMNivZaabkZM=; b=m78GFEIt6bIb+dvK/EqAgTyS8/ov4uDrrh+w+NIK+V06qBxmO+oJiaSBMC4CwuAZKn wKaTOW+QIjvtbjrIy+fJ+kKzmItCQ0DibqmPPKITA4tfRlnh8P0FPb47+QICvktLwykt eB8/yrY7a/0cer6r/ZW+p2quTz9Smw8cZajNe29Htn/wvPyYwWhZ78Iyf6wY4RD/TRsj oxjNo162zPylx6OgWh9aoPsCT4Gcha651/Q+n6sAXjEpOOfOJ6G/K7FdxGExo3Pw2O2d APkgfbomNYyUR+Jjyoyi/cQiBoNvXQqUs5dbqg2n9eusftsYtIZ+kFVTo69ADkmBcu8x eDxw== X-Gm-Message-State: AOAM530zSA7DOVooYVF54nAAMC5isQHbYlOzsCqIV4fPNJpg3DiQ+aEr /hU/cdxYYlbkmRp66cYAsq1fBlkKpreQm5OHE3i9fqRnlVw= X-Google-Smtp-Source: ABdhPJwC0+GmcxhlaFtb7Nng99Jh68g0RfBT4wMNoT0eCS7yfYKxAV4qCce3iSSFmu5zQF/aRnl7t/167YGaxhGlq+E= X-Received: by 2002:a2e:9b14:: with SMTP id u20mr1598050lji.463.1615377464661; Wed, 10 Mar 2021 03:57:44 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a2e:b54e:0:0:0:0:0 with HTTP; Wed, 10 Mar 2021 03:57:44 -0800 (PST) In-Reply-To: <202103091117.129BHOZa042851@gitrepo.freebsd.org> References: <202103091117.129BHOZa042851@gitrepo.freebsd.org> From: Mateusz Guzik Date: Wed, 10 Mar 2021 12:57:44 +0100 Message-ID: Subject: Re: git: 1ae20f7c70ea - main - kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() To: Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DwVvG27Hpz3CPp X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qbRy7xBn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::235 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.52 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::235:from]; TO_DN_SOME(0.00)[]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::235:from:127.0.2.255]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::235:from]; NEURAL_HAM_SHORT(-0.52)[-0.515]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 11:57:47 -0000 There is something very wrong going on here. Key thing to note is that malloc is ultimately a wrapper around uma_zalloc. Whatever asserts you may want to add to malloc to catch problems sooner, should also present in uma. uma has the following: if (flags & M_WAITOK) { WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, "uma_zalloc_debug: zone \"%s\"", zone->uz_name); } This code used to execute prior to this commit and fail to catch the problems which got reported already. In other words: - WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK is incomplete in terms of internals its internals - the above should be in malloc, perhaps after being abstracted into a an assert-helper - fixing witness deficiency will probably find a slew of new problems - this should remain as a warning (maybe rate-limited) for the foreseable future On 3/9/21, Kyle Evans wrote: > The branch main has been updated by kevans: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=1ae20f7c70ea16fa8b702e409030e170df4f5c13 > > commit 1ae20f7c70ea16fa8b702e409030e170df4f5c13 > Author: Kyle Evans > AuthorDate: 2021-03-08 06:16:27 +0000 > Commit: Kyle Evans > CommitDate: 2021-03-09 11:16:39 +0000 > > kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() > > Simple condition flip; we wanted to panic here after > epoch_trace_list(). > > Reviewed by: glebius, markj > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D29125 > --- > sys/kern/kern_malloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/kern/kern_malloc.c b/sys/kern/kern_malloc.c > index 48383358e3ad..0d6f9dcfcab7 100644 > --- a/sys/kern/kern_malloc.c > +++ b/sys/kern/kern_malloc.c > @@ -537,7 +537,7 @@ malloc_dbg(caddr_t *vap, size_t *sizep, struct > malloc_type *mtp, > #ifdef EPOCH_TRACE > epoch_trace_list(curthread); > #endif > - KASSERT(1, > + KASSERT(0, > ("malloc(M_WAITOK) with sleeping prohibited")); > } > } > -- Mateusz Guzik