From owner-freebsd-net@FreeBSD.ORG  Tue Feb  4 07:28:00 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 669968E5;
 Tue,  4 Feb 2014 07:28:00 +0000 (UTC)
Received: from cc-smtpout2.netcologne.de (cc-smtpout2.netcologne.de
 [IPv6:2001:4dd0:100:1062:25:2:0:2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1E49E1B65;
 Tue,  4 Feb 2014 07:28:00 +0000 (UTC)
Received: from cc-smtpin1.netcologne.de (cc-smtpin1.netcologne.de [89.1.8.201])
 by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 66DE6121AF;
 Tue,  4 Feb 2014 08:27:50 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by cc-smtpin1.netcologne.de (Postfix) with ESMTP id 61E9D11DBE;
 Tue,  4 Feb 2014 08:27:50 +0100 (CET)
Received: from [109.44.3.238] (helo=cc-smtpin1.netcologne.de)
 by localhost with ESMTP (eXpurgate 4.0.2)
 (envelope-from <saw@online.de>)
 id 52f09676-1380-7f0000012729-7f000001831d-1
 for <multiple-recipients>; Tue, 04 Feb 2014 08:27:50 +0100
Received: from collider (ip-109-44-3-238.web.vodafone.de [109.44.3.238])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by cc-smtpin1.netcologne.de (Postfix) with ESMTPSA;
 Tue,  4 Feb 2014 08:27:40 +0100 (CET)
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
To: lists@eitanadler.com, "Hiroki Sato" <hrs@freebsd.org>
Subject: Re: ip6opt.c
References: <CAF6rxgmQMXKDMETRPRE-QkQwGS3vgZxQRFKoe6d3_BycQOouYw@mail.gmail.com>
 <20140204.052625.1192023326694116318.hrs@allbsd.org>
Date: Tue, 04 Feb 2014 08:27:36 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Sascha Wildner" <saw@online.de>
Message-ID: <op.xaqxoaxur9a2dd@collider>
In-Reply-To: <20140204.052625.1192023326694116318.hrs@allbsd.org>
User-Agent: Opera Mail/1.0 (Win32)
Cc: freebsd-net@freebsd.org, swildner@dragonflybsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 07:28:00 -0000

On Mon, 03 Feb 2014 21:26:25 +0100, Hiroki Sato <hrs@freebsd.org> wrote:

> Eitan Adler <lists@eitanadler.com> wrote
>   in  
> <CAF6rxgmQMXKDMETRPRE-QkQwGS3vgZxQRFKoe6d3_BycQOouYw@mail.gmail.com>:
>
> li> Hi all,
> li>
> li> DragonFly recently committed the following change and it seems that  
> it
> li> applies to us as well.
> li>
> li>  
> http://gitweb.dragonflybsd.org/dragonfly.git/blobdiff/5764e12516158974fac10d50dbd2df76ce1ab007..98651c6e0e1c3b7a6b8650b55b473fcc745a22b7:/lib/libc/net/ip6opt.c
> li>
> li> Should I commit it?
>
>  Just out of curiousity, what is the problem with returning -1 when
>  (extbuf == NULL) && (extlen % 8) != 0?

I read the RFC as saying that the extlen check should be performed in the  
extbuf != NULL case, not when it is NULL. No real problem, really.

Sascha