Date: Tue, 04 Feb 2014 08:27:36 +0100 From: "Sascha Wildner" <saw@online.de> To: lists@eitanadler.com, "Hiroki Sato" <hrs@freebsd.org> Cc: freebsd-net@freebsd.org, swildner@dragonflybsd.org Subject: Re: ip6opt.c Message-ID: <op.xaqxoaxur9a2dd@collider> In-Reply-To: <20140204.052625.1192023326694116318.hrs@allbsd.org> References: <CAF6rxgmQMXKDMETRPRE-QkQwGS3vgZxQRFKoe6d3_BycQOouYw@mail.gmail.com> <20140204.052625.1192023326694116318.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 03 Feb 2014 21:26:25 +0100, Hiroki Sato <hrs@freebsd.org> wrote: > Eitan Adler <lists@eitanadler.com> wrote > in > <CAF6rxgmQMXKDMETRPRE-QkQwGS3vgZxQRFKoe6d3_BycQOouYw@mail.gmail.com>: > > li> Hi all, > li> > li> DragonFly recently committed the following change and it seems that > it > li> applies to us as well. > li> > li> > http://gitweb.dragonflybsd.org/dragonfly.git/blobdiff/5764e12516158974fac10d50dbd2df76ce1ab007..98651c6e0e1c3b7a6b8650b55b473fcc745a22b7:/lib/libc/net/ip6opt.c > li> > li> Should I commit it? > > Just out of curiousity, what is the problem with returning -1 when > (extbuf == NULL) && (extlen % 8) != 0? I read the RFC as saying that the extlen check should be performed in the extbuf != NULL case, not when it is NULL. No real problem, really. Sascha
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.xaqxoaxur9a2dd>