From owner-freebsd-stable@FreeBSD.ORG Fri Dec 17 01:10:32 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E43AA106566C for ; Fri, 17 Dec 2010 01:10:32 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 919BE8FC16 for ; Fri, 17 Dec 2010 01:10:32 +0000 (UTC) Received: by ywp6 with SMTP id 6so74485ywp.13 for ; Thu, 16 Dec 2010 17:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :organization:user-agent:mime-version:to:cc:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=X28Nglm4NRlpTKI1+K1NaXo7x0iVPGBeP+Ifna5LvTY=; b=sAM9s1L3AHd9E9V4+e86uJCFOp7xQ3TU6uzaoBhpHamyWXc0ouMHohmwaAeNT4T4l+ bRumGimecPmMBEiAzHd0zSOH9lR5ypvVsYPbCfv+QDNmN4pkDRnFZ9J/WkVO0HLCTS0l +LzqM/VrCSocl8w7QhFpSowFvqxOD/HXUlCaw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=MDKE5Y31UJsYUU+24om8O8NswjoAKs88KdUV0VEp0yH/GC5zIkjAuVYaj8dmDto40O T+udkCe/UIiGltiZTSUFqQbDWtNGp6JG+CNrraBAQ68TV/1ZDZo7wcUviUHUagq1n0r4 u1SALBqQ/U8QSgY4qZWKEOItCgDnBT5z1YjDg= Received: by 10.150.54.13 with SMTP id c13mr1930966yba.331.1292548231556; Thu, 16 Dec 2010 17:10:31 -0800 (PST) Received: from centel.dataix.local (adsl-99-109-125-135.dsl.klmzmi.sbcglobal.net [99.109.125.135]) by mx.google.com with ESMTPS id r24sm5145092yba.6.2010.12.16.17.10.28 (version=SSLv3 cipher=RC4-MD5); Thu, 16 Dec 2010 17:10:29 -0800 (PST) Sender: "J. Hellenthal" Message-ID: <4D0AB882.5090800@DataIX.net> Date: Thu, 16 Dec 2010 20:10:26 -0500 From: jhell Organization: http://www.DataIX.net User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.13) Gecko/20101210 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: Kostik Belousov References: <4D02CA9E.1030704@janh.de> <4D02D736.7000103@sentex.net> <20101211160121.GL33073@deviant.kiev.zoral.com.ua> <4D040458.3030601@sentex.net> <20101211232253.GR33073@deviant.kiev.zoral.com.ua> <4D04195F.1080802@sentex.net> <20101212084327.GS33073@deviant.kiev.zoral.com.ua> In-Reply-To: <20101212084327.GS33073@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jan Henrik Sylvester , stable-list freebsd Subject: Re: aesni(?) corrupts data on 8.2-BETA1 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 01:10:33 -0000 On 12/12/2010 03:43, Kostik Belousov wrote: > On Sat, Dec 11, 2010 at 07:37:51PM -0500, Mike Tancsa wrote: >> On 12/11/2010 6:22 PM, Kostik Belousov wrote: >>> On Sat, Dec 11, 2010 at 06:08:08PM -0500, Mike Tancsa wrote: >>>> On 12/11/2010 11:01 AM, Kostik Belousov wrote: >>>>> >>>>> I have no access to AESNI hardware. For start, you may use >>>>> src/tools/tools/crypto/cryptotest >>>>> to somewhat verify the sanity of the driver. >>>> >>>> I doesnt happen every time, but one out of 5 or so >>>> >>> First, which arch is it, amd64 or i386 ? >>> >>> Also, please revert r216162 and do the same tests. >> >> Hi, >> Its AMD64, but i386 seems to be impacted too. I am not sure how to >> revert to a specific commit, but for now I csup'd with a date tag of >> >> *date=2010.12.02.23.00.00 >> >> which is a day before >> http://lists.freebsd.org/pipermail/svn-src-stable-8/2010-December/004338.html >> >> >> And that seems to fix it! >> >> I have been running >> cryptotest -c -z -t 10 >> in a loop for the past 10min and not one error. > > Please try this patch on the latest HEAD or RELENG_8. > > diff --git a/sys/amd64/amd64/fpu.c b/sys/amd64/amd64/fpu.c > index 482b5da..1b493b4 100644 > --- a/sys/amd64/amd64/fpu.c > +++ b/sys/amd64/amd64/fpu.c > @@ -426,7 +426,9 @@ fpudna(void) > fxrstor(&fpu_initialstate); > if (pcb->pcb_initial_fpucw != __INITIAL_FPUCW__) > fldcw(pcb->pcb_initial_fpucw); > - fpuuserinited(curthread); > + pcb->pcb_flags |= PCB_FPUINITDONE; > + if (PCB_USER_FPU(pcb)) > + pcb->pcb_flags |= PCB_USERFPUINITDONE; > } else > fxrstor(pcb->pcb_save); > critical_exit(); > diff --git a/sys/i386/isa/npx.c b/sys/i386/isa/npx.c > index 9ec5d25..f314e44 100644 > --- a/sys/i386/isa/npx.c > +++ b/sys/i386/isa/npx.c > @@ -684,7 +684,9 @@ npxdna(void) > fpurstor(&npx_initialstate); > if (pcb->pcb_initial_npxcw != __INITIAL_NPXCW__) > fldcw(pcb->pcb_initial_npxcw); > - npxuserinited(curthread); > + pcb->pcb_flags |= PCB_NPXINITDONE; > + if (PCB_USER_FPU(pcb)) > + pcb->pcb_flags |= PCB_NPXUSERINITDONE; > } else { > /* > * The following fpurstor() may cause an IRQ13 when the Regarding this patch(r216455) and r216162 I have had to back both of them out of my local tree to avoid panics on a ZFS & UFS2 i386 system. With the following panic strings: Dumptime: Thu Dec 9 08:37:40 2010 Panic String: double fault Dumptime: Thu Dec 9 08:41:57 2010 Panic String: page fault Dumptime: Fri Dec 10 00:23:35 2010 Panic String: free: address 0x85ceb000(0x85ceb000) has not been allocated. Dumptime: Fri Dec 10 14:37:33 2010 Panic String: page fault Dumptime: Sat Dec 11 04:10:01 2010 Panic String: vm_fault: fault on nofault entry, addr: 8289c000 Dumptime: Sun Dec 12 23:45:01 2010 Panic String: page fault Dumptime: Tue Dec 14 01:32:09 2010 Panic String: page fault Dumptime: Tue Dec 14 16:46:33 2010 Panic String: general protection fault Dumptime: Thu Dec 16 10:03:15 2010 Panic String: vm_fault: fault on nofault entry, addr: b3811000 Seems to be caused by r216162 or directly related to it. If further information is needed let me know. Ill be around here for the next few hours. -- jhell,v