From nobody Mon Oct 21 15:11:11 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XXJfm0LvHz5ZP8H; Mon, 21 Oct 2024 15:11:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XXJfl5nzSz4lPP; Mon, 21 Oct 2024 15:11:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729523471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JQAVuTg4pUjvNYIaHDGh0TfiLiHB7+UPSSQgAiVyqPk=; b=cRJUYCXI9aqzgugoRyVGyHGhBgOkKsROSPdf8xJNc0uFwAWUhatbmaXXy37fn4qnOM7Fy3 JRaj2v3VnDl5hc/xhCmLfj5wdMvUqYwEJqX5LZj453zejZjmlYaY6C7Tl/uvsEr6p+t5wL YLiPtk/yjrxQGmgVuUESMza9M6SLkeo1dOOyPheEvObCg33cOWRQLK+WbnZ40UBXWHVOGu UMGnZ9Lwl1KXAotpMkiWbsSXRjcZa/jRI4DfxcuQrvD0gkyCFEIdR0AApyBkeWL9KZLZHL rc7K+8zOpJbfqixHukz3J5DGubsheMZ4gQC6ShRx9I2h4J2c2TkWzGcYYCkQYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729523471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JQAVuTg4pUjvNYIaHDGh0TfiLiHB7+UPSSQgAiVyqPk=; b=B9pBbYYhhdUBjbMhO+WFhzREvkbchlhsVv/IPEy9+cCnBXfhxICaE2FnsRo10HEgK4KI0F 7NDOwiQ4M9MnxnCxSsX5nJFFHQuJMSUoWUvH21V5gUm3Peua/bdrazQIffJq1xA0DdvI4x TQqA9hFUCP7SyfZiUcI5i4EEH2XPiCLr1JN7vjWJgr4aWWzlDgx1IwAr6KhPXbjQ3sfySc hCbO9zE66ABTSAfmpxDucErFncaDlODUvzUeOPuOiPNtV65vwyH3METnBY0p6/++FDporp FPaAb46cM/8i8fGQV4OVbDxRJ/HhwGO+NNJcrOSRm1zuMsdBqZSvCFQhDv1lJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729523471; a=rsa-sha256; cv=none; b=A2FjZ3lzMwqEU+/KS56AujtyHFCooSejDLoH6WP0W3ju6yviQwDJeNPiG7fdArJG2jxgur hfaqKTP52dz7nibVCv7BplC4eXpnDuugHUSbqT4OvkvkCWbtBI8bZwAZA+e5fGSbsSxkNl 5k9ogK1Surng0s8t3p2Scz6MGsJjWkW59Emk324kWF69x/4lfnT+e1oiT6Tw/iit9AhMXT KLl6D72n1JR6Huq/dOD9/pDkUdZhU8J/M6EzRWIiS4WtRKJYazGnNBN0ug6BaqbkEGFwWN BuyQHglD0++NOJNOSjJSuAMo9F+W6d8oqPQo0YwePGSUc3qcam9RyzIA7lJ4ig== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XXJfl55w3zb1p; Mon, 21 Oct 2024 15:11:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49LFBBZB060458; Mon, 21 Oct 2024 15:11:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49LFBBo7060455; Mon, 21 Oct 2024 15:11:11 GMT (envelope-from git) Date: Mon, 21 Oct 2024 15:11:11 GMT Message-Id: <202410211511.49LFBBo7060455@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 4c1441bba1d1 - stable/14 - igc: Add sysctl for DMA Coalesce List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4c1441bba1d1bcc5a8237c97f136bf7e3cc77058 Auto-Submitted: auto-generated The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=4c1441bba1d1bcc5a8237c97f136bf7e3cc77058 commit 4c1441bba1d1bcc5a8237c97f136bf7e3cc77058 Author: Kevin Bowling AuthorDate: 2024-10-14 12:55:18 +0000 Commit: Kevin Bowling CommitDate: 2024-10-21 15:09:35 +0000 igc: Add sysctl for DMA Coalesce This feature can increase efficiency at the expense of latency It does not work well with the default interrupt delay, but expose the otherwise unconnected code in the driver in case people want to experiment. See https://www.intel.com/content/dam/support/us/en/documents/network/adapter/pro100/sb/466827_intel_r__dma_coalescing_white_paper_v003.pdf Sponsored by: BBOX.io (cherry picked from commit 68b1f5dc59368ce5175e3300bf95476ea5a560bc) --- sys/dev/igc/if_igc.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index d964fbe4cf91..da897d636cfe 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -141,6 +141,7 @@ static int igc_msix_link(void *); static void igc_handle_link(void *context); static int igc_set_flowcntl(SYSCTL_HANDLER_ARGS); +static int igc_sysctl_dmac(SYSCTL_HANDLER_ARGS); static int igc_sysctl_eee(SYSCTL_HANDLER_ARGS); static int igc_get_regs(SYSCTL_HANDLER_ARGS); @@ -490,6 +491,12 @@ igc_if_attach_pre(if_ctx_t ctx) CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT, adapter, 0, igc_get_rs, "I", "Dump RS indexes"); + SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev), + SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), + OID_AUTO, "dmac", + CTLTYPE_INT | CTLFLAG_RW, adapter, 0, + igc_sysctl_dmac, "I", "DMA Coalesce"); + /* Determine hardware and mac info */ igc_identify_hardware(ctx); @@ -3030,6 +3037,55 @@ igc_set_flowcntl(SYSCTL_HANDLER_ARGS) return (error); } +/* + * Manage DMA Coalesce: + * Control values: + * 0/1 - off/on + * Legal timer values are: + * 250,500,1000-10000 in thousands + */ +static int +igc_sysctl_dmac(SYSCTL_HANDLER_ARGS) +{ + struct igc_adapter *sc = (struct igc_adapter *) arg1; + int error; + + error = sysctl_handle_int(oidp, &sc->dmac, 0, req); + + if ((error) || (req->newptr == NULL)) + return (error); + + switch (sc->dmac) { + case 0: + /* Disabling */ + break; + case 1: /* Just enable and use default */ + sc->dmac = 1000; + break; + case 250: + case 500: + case 1000: + case 2000: + case 3000: + case 4000: + case 5000: + case 6000: + case 7000: + case 8000: + case 9000: + case 10000: + /* Legal values - allow */ + break; + default: + /* Do nothing, illegal value */ + sc->dmac = 0; + return (EINVAL); + } + /* Reinit the interface */ + igc_if_init(sc->ctx); + return (error); +} + /* * Manage Energy Efficient Ethernet: * Control values: