From owner-freebsd-hackers  Tue Apr 28 20:42:29 1998
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id UAA29446
          for freebsd-hackers-outgoing; Tue, 28 Apr 1998 20:42:29 -0700 (PDT)
          (envelope-from owner-freebsd-hackers@FreeBSD.ORG)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA29441
          for <freebsd-hackers@FreeBSD.ORG>; Tue, 28 Apr 1998 20:42:24 -0700 (PDT)
          (envelope-from root@implode.root.com)
Received: from implode.root.com (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with ESMTP id UAA27324;
	Tue, 28 Apr 1998 20:41:41 -0700 (PDT)
Message-Id: <199804290341.UAA27324@implode.root.com>
To: msuarez@cybernet.com
cc: FreeBSD Hackers <freebsd-hackers@FreeBSD.ORG>
Subject: Re: Kernel Programming Question 
In-reply-to: Your message of "Tue, 28 Apr 1998 15:35:13 EDT."
             <XFMail.980428153513.msuarez@cybernet.com> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Tue, 28 Apr 1998 20:41:41 -0700
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

...
>             error=vn_rdwr(UIO_READ,imgp->vp,(void *) buf,PAGE_SIZE,offset,
>                           UIO_SYSSPACE,IO_NODELOCKED,p->p_ucred,&resid,p);
>             if(!error) 
>              {
>               int t=0;
>               if(resid) bzero((char *)buf+PAGE_SIZE-resid,resid);
>               for(t=0; t<PAGE_SIZE-resid; t++) sum+=buf[t];
                         ^^^^^^^^^^^^^^^^^

   Don't you want that to be:

              for(t=0; t < (resid ? resid : PAGE_SIZE); t++) sum+=buf[t];

? (Or perhaps something a bit more optimized)

   Otherwise, I don't see anything obviously wrong that would cause the
system to hang...but then, I have very little experiance using vn_rdwr(),
so I could easily be forgetting something.

-DG

David Greenman
Co-founder/Principal Architect, The FreeBSD Project

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message