From owner-freebsd-current Tue Nov 23 22:57:58 1999 Delivered-To: freebsd-current@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id 9F1C514DB2; Tue, 23 Nov 1999 22:57:51 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (root@d60-025.leach.ucdavis.edu [169.237.60.25]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id WAA56553; Tue, 23 Nov 1999 22:57:50 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.9.3/8.9.1) id WAA52031; Tue, 23 Nov 1999 22:57:50 -0800 (PST) (envelope-from obrien) Date: Tue, 23 Nov 1999 22:57:50 -0800 From: "David O'Brien" To: Kris Kennaway Cc: current@freebsd.org Subject: Re: Overflow in banner(1) Message-ID: <19991123225750.F49362@dragon.nuxi.com> Reply-To: obrien@NUXI.com References: <19991123224424.B51939@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from kris@hub.freebsd.org on Tue, Nov 23, 1999 at 10:51:11PM -0800 X-Operating-System: FreeBSD 4.0-CURRENT Organization: The NUXI BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > - (void)fgets(message, sizeof(message), stdin); > > > + (void)fgets(message, MAXMSG, stdin); > > > > There is nothing wrong with the original line here. Please don't change > > things that are fine just to change them. We don't want to ofuscate > > Obviously not, but I didn't see the point in making it inconsistent. You could make the "MAXMSG" you added "sizeof(message)" and been consistent. :) -- -- David (obrien@NUXI.com) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message