From owner-freebsd-current@FreeBSD.ORG  Wed Jun 27 16:06:46 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 13FD1106564A
	for <current@freebsd.org>; Wed, 27 Jun 2012 16:06:46 +0000 (UTC)
	(envelope-from ken@kdm.org)
Received: from nargothrond.kdm.org (nargothrond.kdm.org [70.56.43.81])
	by mx1.freebsd.org (Postfix) with ESMTP id D03C98FC18
	for <current@freebsd.org>; Wed, 27 Jun 2012 16:06:45 +0000 (UTC)
Received: from nargothrond.kdm.org (localhost [127.0.0.1])
	by nargothrond.kdm.org (8.14.2/8.14.2) with ESMTP id q5RG6jqh002261;
	Wed, 27 Jun 2012 10:06:45 -0600 (MDT)
	(envelope-from ken@nargothrond.kdm.org)
Received: (from ken@localhost)
	by nargothrond.kdm.org (8.14.2/8.14.2/Submit) id q5RG6hfm002260;
	Wed, 27 Jun 2012 10:06:43 -0600 (MDT) (envelope-from ken)
Date: Wed, 27 Jun 2012 10:06:43 -0600
From: "Kenneth D. Merry" <ken@freebsd.org>
To: Michael Butler <imb@protected-networks.net>
Message-ID: <20120627160643.GA2225@nargothrond.kdm.org>
References: <4FE9D958.4000901@protected-networks.net>
	<alpine.GSO.1.10.1206261929300.18441@multics.mit.edu>
	<20120627022909.GA153@nargothrond.kdm.org>
	<4FEB1743.506@protected-networks.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FEB1743.506@protected-networks.net>
User-Agent: Mutt/1.4.2i
Cc: Benjamin Kaduk <kaduk@mit.edu>, current@freebsd.org
Subject: Re: Removing an SDHC card causes a kernel panic on -current
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2012 16:06:46 -0000

On Wed, Jun 27, 2012 at 10:22:59 -0400, Michael Butler wrote:
> On 06/26/12 22:29, Kenneth D. Merry wrote:
> > On Tue, Jun 26, 2012 at 19:41:07 -0400, Benjamin Kaduk wrote:
> >> On Tue, 26 Jun 2012, Michael Butler wrote:
> >>
> >>> As follows, in "g_disk_providergone", a NULL pointer reference?:
> >>
> >> g_disk_providergone() is new in r237518 (by ken); ken cc'd.
> > 
> > Can you try the attached patch to sys/geom/geom_disk.c?
> 
> This fixes the panic :-)

Great!  I just committed it.

> > Also, do you have full dmesg information for when the panic happened?
> > 
> > It looks like disk_destroy() has already been called in this case, and I
> > suppose that's likely to happen for any of the users of the GEOM disk class
> > that haven't been updated with the reference count changes I made in da(4).
> > (i.e. all of the rest of them.)
> > 
> > Let me know whether this works for you.
> 
> All I have is the following leading up to my removal of the card (and
> the restart afterwards):

Thanks!

Ken
-- 
Kenneth Merry
ken@FreeBSD.ORG