From owner-freebsd-current@FreeBSD.ORG Thu Oct 9 15:10:08 2014 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 945EA952; Thu, 9 Oct 2014 15:10:08 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 5A482BA0; Thu, 9 Oct 2014 15:10:07 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA15680; Thu, 09 Oct 2014 18:10:05 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1XcFLx-0005HM-Ir; Thu, 09 Oct 2014 18:10:05 +0300 Message-ID: <5436A52A.30802@FreeBSD.org> Date: Thu, 09 Oct 2014 18:09:30 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Nathan Whitehorn , freebsd-current@FreeBSD.org Subject: Re: vt_suspend / vt_resume References: <542A43E1.5010401@FreeBSD.org> <542EBD1F.2060604@FreeBSD.org> <542EBEF1.1080200@freebsd.org> In-Reply-To: <542EBEF1.1080200@freebsd.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 15:10:08 -0000 On 03/10/2014 18:21, Nathan Whitehorn wrote: > > On 10/03/14 08:13, Andriy Gapon wrote: >> The patch (I am not sure if fbd_attach is the right place to register the event >> handlers): > > It's not, I don't think, since fbd_attach() isn't called for all vt backends > (e.g. the VGA and EFI backends don't call it). vt_fb_suspend() also only calls > vt_suspend(), so it's probably best to put this in the core vt code. I looked at the vt code and I was not able to figure out what would be the proper place there. Initially I thought that vt_allocate() would be it, but then it seems that vt_allocate() might not be called. So, perhaps vtterm_cnprobe() ? Something else? Thanks! -- Andriy Gapon