From owner-svn-src-all@FreeBSD.ORG Tue Jun 3 19:44:02 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 98EAD829; Tue, 3 Jun 2014 19:44:02 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 56CB222A7; Tue, 3 Jun 2014 19:44:02 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s53Ji0fU044709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Jun 2014 12:44:01 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s53Ji0lg044708; Tue, 3 Jun 2014 12:44:00 -0700 (PDT) (envelope-from jmg) Date: Tue, 3 Jun 2014 12:44:00 -0700 From: John-Mark Gurney To: Ivan Voras Subject: Re: svn commit: r266972 - head/sbin/geom/class/label Message-ID: <20140603194400.GG31367@funkthat.com> References: <201406021505.s52F5P1D064451@svn.freebsd.org> <20140602223124.GB43976@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Tue, 03 Jun 2014 12:44:01 -0700 (PDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 19:44:02 -0000 Ivan Voras wrote this message on Tue, Jun 03, 2014 at 21:31 +0200: > None of the other classes have the sysctls documented here, there's > only a description of the kern.geom.label.debug flag. That's probably because people haven't spent much time documenting their code... Just because other classes have bad documentation doesn't mean glabel should have bad docs... If you don't want to document the sysctl's on glabel(8), another option is to create a new page, glabel(9), xref it on glabel(8) and document it there, but that seems excesive, unless you need to document more specific kernel features of glabel... Plus, it'd make it harder for users to track down.. > I guess adding a wildcard catch-all section for the > kern.geom.label.*.enable would be best here. Yes, that would be useful, even just mentioning the sysctl tree is good... And since we've started adding descriptions to your sysctls, they are somewhat self documenting now, just need to know that they exist... Thanks. > On 3 June 2014 00:31, John-Mark Gurney wrote: > > Ivan Voras wrote this message on Mon, Jun 02, 2014 at 15:05 +0000: > >> Author: ivoras > >> Date: Mon Jun 2 15:05:25 2014 > >> New Revision: 266972 > >> URL: http://svnweb.freebsd.org/changeset/base/266972 > >> > >> Log: > >> Document the diskid automatic label class. > >> While there, also document the glabel "native" labels and explain why > >> there are additional nodes created for nested GEOM classes. > >> > >> Reminded by: jmg > > > > Shouldn't kern.geom.label.disk_ident.enable also be documented here? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."