From owner-svn-src-all@FreeBSD.ORG Mon Sep 20 12:44:31 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2C371065670; Mon, 20 Sep 2010 12:44:31 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au [211.29.132.185]) by mx1.freebsd.org (Postfix) with ESMTP id 234CB8FC19; Mon, 20 Sep 2010 12:44:30 +0000 (UTC) Received: from besplex.bde.org (c122-107-116-249.carlnfd1.nsw.optusnet.com.au [122.107.116.249]) by mail04.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o8KCiNJg029760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Sep 2010 22:44:28 +1000 Date: Mon, 20 Sep 2010 22:44:23 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ed Schouten In-Reply-To: <201009191635.o8JGZgF3008282@svn.freebsd.org> Message-ID: <20100920224337.E63497@besplex.bde.org> References: <201009191635.o8JGZgF3008282@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212867 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2010 12:44:31 -0000 On Sun, 19 Sep 2010, Ed Schouten wrote: > Log: > Just make callout devices and /dev/console force CLOCAL on open(). > > Instead of adding custom checks to wait for DCD on open(), just modify > the termios structure to set CLOCAL. This means SIGHUP is no longer > generated when losing DCD as well. > > Reviewed by: kib@ > MFC after: 1 week Er, my review explained how wrong this is. Please back it out. Bruce