Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Aug 2015 11:48:26 +0800
From:      Marcelo Araujo <araujobsdport@gmail.com>
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        Ed Schouten <ed@nuxi.nl>, src-committers <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r286266 - head/usr.bin/ypmatch
Message-ID:  <CAOfEmZhCoKhrcRK-AJsx_W8X9DSvw=BcYaTCZejvYH-24dhO4Q@mail.gmail.com>
In-Reply-To: <20150810131627.F965@besplex.bde.org>
References:  <201508040234.t742YqQA045448@repo.freebsd.org> <CABh_MK=5O=TLQmwr%2BwrdJeBVK3ATma1S1yj1_4kv-en9LzVOyA@mail.gmail.com> <CAOfEmZgiuzVQY%2BxgnGmiRv=1OrkUqFLqfoS5V92_8XLExcTmLA@mail.gmail.com> <20150810131627.F965@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--e89a8fb1f32aa29be4051cecdb5b
Content-Type: text/plain; charset=UTF-8

Hi bde@ and ed@

I think the patch attached is the latest changes to bring it as it used to
be before I synced the code with OpenBSD.

Mostly all issues that you both pointed out were addressed.
Could you both make a review and point to me if there is any issue still
remain?

Basically this patch address:
- Remove the extra information at the usage().
- Add space between variables on while() and for().
- Remove the extra space in a if statement.
- Remove the extra brackets.
- s/Reason/reason/g.

All the best.

2015-08-10 11:24 GMT+08:00 Bruce Evans <brde@optusnet.com.au>:

> On Mon, 10 Aug 2015, Marcelo Araujo wrote:
>
> 2015-08-09 19:51 GMT+08:00 Ed Schouten <ed@nuxi.nl>:
>>
>> Hi Marcelo,
>>>
>>> 2015-08-04 4:34 GMT+02:00 Marcelo Araujo <araujo@freebsd.org>:
>>>
>>>>   Sync the code with the OpenBSD version.
>>>>
>>>
>>> That's a shame. It looks like improvements that we made to our version
>>> have been undone because of this.
>>> ...
>>> Though the style(9) conformance of tool wasn't ideal, this change made it
>>> worse.
>>>
>>
>> Agree with you!
>>
>> These tools are original from OpenBSD, I'm trying first to sync the code
>> and then will rework them. I will try to send it back to upstream(OpenBSD)
>> as soon as I have time.
>>
>
> In fact, the changes were more than half to back out FreeBSD cleanups by
> syncing with the 1994 OpenBSD version.  The cleanups were small (less
> than 50 lines changed), and OpenBSD doesn't seem to have changed much
> either.
>
> Bruce
>



-- 

-- 
Marcelo Araujo            (__)araujo@FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>;   \/  \ ^
Power To Server.         .\. /_)

--e89a8fb1f32aa29be4051cecdb5b
Content-Type: text/plain; charset=US-ASCII; name="ypmatch.diff"
Content-Disposition: attachment; filename="ypmatch.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_id5dnouh0

SW5kZXg6IHlwbWF0Y2guYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB5cG1hdGNoLmMJKHJldmlzaW9uIDI4NjU2
MikKKysrIHlwbWF0Y2guYwkod29ya2luZyBjb3B5KQpAQCAtNjgsMTIgKzY4LDYgQEAKIAlmcHJp
bnRmKHN0ZGVyciwgIiVzXG4lc1xuIiwKIAkgICAgInVzYWdlOiB5cG1hdGNoIFsta3RdIFstZCBk
b21haW5uYW1lXSBrZXkgLi4uIG1hcG5hbWUiLAogCSAgICAiICAgICAgIHlwbWF0Y2ggLXgiKTsK
LQlmcHJpbnRmKHN0ZGVyciwKLQkgICAgIndoZXJlXG4iCi0JICAgICJcdG1hcG5hbWUgbWF5IGJl
IGVpdGhlciBhIG1hcG5hbWUgb3IgYSBuaWNrbmFtZSBmb3IgYSBtYXAuXG4iCi0JICAgICJcdC1r
IHByaW50cyBrZXlzIGFzIHdlbGwgYXMgdmFsdWVzLlxuIgotCSAgICAiXHQtdCBpbmhpYml0cyBt
YXAgbmlja25hbWUgdHJhbnNsYXRpb24uXG4iCi0JICAgICJcdC14IGR1bXBzIHRoZSBtYXAgbmlj
a25hbWUgdHJhbnNsYXRpb24gdGFibGUuXG4iKTsKIAlleGl0KDEpOwogfQogCkBAIC04NywxMCAr
ODEsMTAgQEAKIAogCWRvbWFpbm5hbWUgPSBOVUxMOwogCW5vdHJhbnMgPSBrZXkgPSAwOwotCXdo
aWxlICgoYz1nZXRvcHQoYXJnYywgYXJndiwgInhkOmt0IikpICE9IC0xKQorCXdoaWxlICgoYyA9
IGdldG9wdChhcmdjLCBhcmd2LCAieGQ6a3QiKSkgIT0gLTEpCiAJCXN3aXRjaCAoYykgewogCQlj
YXNlICd4JzoKLQkJCWZvciAoaT0wOyBpPHNpemVvZiB5cGFsaWFzZXMvc2l6ZW9mIHlwYWxpYXNl
c1swXTsgaSsrKQorCQkJZm9yIChpID0gMDsgaTxzaXplb2YgeXBhbGlhc2VzL3NpemVvZiB5cGFs
aWFzZXNbMF07IGkrKykKIAkJCQlwcmludGYoIlVzZSBcIiVzXCIgZm9yIFwiJXNcIlxuIiwKIAkJ
CQkJeXBhbGlhc2VzW2ldLmFsaWFzLAogCQkJCQl5cGFsaWFzZXNbaV0ubmFtZSk7CkBAIC0xMDgs
MTYgKzEwMiwxNSBAQAogCQkJdXNhZ2UoKTsKIAkJfQogCi0JaWYgKChhcmdjLW9wdGluZCkgPCAy
ICkKKwlpZiAoKGFyZ2Mtb3B0aW5kKSA8IDIpCiAJCXVzYWdlKCk7CiAKLQlpZiAoZG9tYWlubmFt
ZSA9PSBOVUxMKSB7CisJaWYgKGRvbWFpbm5hbWUgPT0gTlVMTCkKIAkJeXBfZ2V0X2RlZmF1bHRf
ZG9tYWluKCZkb21haW5uYW1lKTsKLQl9CiAKIAlpbm1hcCA9IGFyZ3ZbYXJnYy0xXTsKIAlpZiAo
bm90cmFucyA9PSAwKSB7Ci0JCWZvciAoaT0wOyBpPHNpemVvZiB5cGFsaWFzZXMvc2l6ZW9mIHlw
YWxpYXNlc1swXTsgaSsrKQorCQlmb3IgKGkgPSAwOyBpPHNpemVvZiB5cGFsaWFzZXMvc2l6ZW9m
IHlwYWxpYXNlc1swXTsgaSsrKQogCQkJaWYgKHN0cmNtcChpbm1hcCwgeXBhbGlhc2VzW2ldLmFs
aWFzKSA9PSAwKQogCQkJCWlubWFwID0geXBhbGlhc2VzW2ldLm5hbWU7CiAJfQpAQCAtMTM3LDcg
KzEzMCw3IEBACiAJCWNhc2UgWVBFUlJfWVBCSU5EOgogCQkJZXJyeCgxLCAibm90IHJ1bm5pbmcg
eXBiaW5kIik7CiAJCWRlZmF1bHQ6Ci0JCQllcnJ4KDEsICJjYW4ndCBtYXRjaCBrZXkgJXMgaW4g
bWFwICVzLiBSZWFzb246ICVzIiwKKwkJCWVycngoMSwgImNhbid0IG1hdGNoIGtleSAlcyBpbiBt
YXAgJXMuIHJlYXNvbjogJXMiLAogCQkJICAgIGlua2V5LCBpbm1hcCwgeXBlcnJfc3RyaW5nKHIp
KTsKIAkJCXJ2YWwgPSAxOwogCQkJYnJlYWs7Cg==
--e89a8fb1f32aa29be4051cecdb5b--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZhCoKhrcRK-AJsx_W8X9DSvw=BcYaTCZejvYH-24dhO4Q>