From owner-svn-src-head@freebsd.org Sun Aug 7 06:53:08 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0BADDBAFD0C for ; Sun, 7 Aug 2016 06:53:08 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-168.reflexion.net [208.70.211.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABC76195A for ; Sun, 7 Aug 2016 06:53:07 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 8271 invoked from network); 7 Aug 2016 06:52:53 -0000 Received: from unknown (HELO mail-cs-02.app.dca.reflexion.local) (10.81.19.2) by 0 (rfx-qmail) with SMTP; 7 Aug 2016 06:52:53 -0000 Received: by mail-cs-02.app.dca.reflexion.local (Reflexion email security v7.90.6) with SMTP; Sun, 07 Aug 2016 02:52:54 -0400 (EDT) Received: (qmail 25748 invoked from network); 7 Aug 2016 06:52:53 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 7 Aug 2016 06:52:53 -0000 X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.0.105] (ip70-189-131-151.lv.lv.cox.net [70.189.131.151]) by iron2.pdx.net (Postfix) with ESMTPSA id 5AAD5B1E001; Sat, 6 Aug 2016 23:52:59 -0700 (PDT) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r303797 - head/contrib/binutils/bfd Message-Id: Date: Sat, 6 Aug 2016 23:52:58 -0700 To: svn-src-head@freebsd.org, jhibbits@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Aug 2016 06:53:08 -0000 Is there to be an MFC for the below? > Author: jhibbits > Date: Sat Aug 6 15:10:14 2016 > New Revision: 303797 > URL:=20 > https://svnweb.freebsd.org/changeset/base/303797 >=20 >=20 > Log: > Check the first byte of the array for NUL, instead of the array as a = NULL pointer > =20 > The partition_name field is an array, so can never be NULL itself. = Check only > the first byte instead. > =20 > This was found when test building with clang, but I'm not sure how = it passes > gcc's warnings either. >=20 > Modified: > head/contrib/binutils/bfd/ppcboot.c >=20 > Modified: head/contrib/binutils/bfd/ppcboot.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/contrib/binutils/bfd/ppcboot.c Sat Aug 6 15:06:19 2016 = (r303796) > +++ head/contrib/binutils/bfd/ppcboot.c Sat Aug 6 15:10:14 2016 = (r303797) > @@ -419,7 +419,7 @@ ppcboot_bfd_print_private_bfd_data (abfd > if (tdata->header.os_id) > fprintf (f, "OS_ID =3D 0x%.2x\n", = tdata->header.os_id); > =20 > - if (tdata->header.partition_name) > + if (tdata->header.partition_name[0]) > fprintf (f, _("Partition name =3D \"%s\"\n"), = tdata->header.partition_name); > =20 > for (i =3D 0; i < 4; i++) =3D=3D=3D Mark Millard markmi at dsl-only.net