From owner-cvs-all Mon Feb 26 3:28:42 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id A729E37B401; Mon, 26 Feb 2001 03:28:34 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA13342; Mon, 26 Feb 2001 22:28:22 +1100 Date: Mon, 26 Feb 2001 22:28:20 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Warner Losh Cc: Doug Barton , "John W. De Boskey" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/disklabel disklabel.8 disklabel.c In-Reply-To: <200102260232.f1Q2W1d10200@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 25 Feb 2001, Warner Losh wrote: > In message <3A99BF5C.252CF8D@gorean.org> Doug Barton writes: > : Warner Losh wrote: > : > > : > In message <200102251647.f1PGliB66323@freefall.freebsd.org> "John W. De Boskey" writes: > : > : This patchset still has style issues and a possible problem on > : > : large disks. However, it was a agreed to get these committed before > : > : performing major surgery on them. > : > > : > The style issues aren't that important, but the problems with very > : > large disks are so don't be in too much of a hurry to MFC these. > : > : Can you define "large" here? It's very much a relative term in today's > : market... "large" means "smaller than any disk you can reasonably buy today". > IIRC, the intereger overflow in the calculations happen in the few > hundred G range, but I may be off by a factor of 10 (eg, a few tens of > Gig or a few Tera). I'll check it out after my next cvsup. Nothing like that. From my review: + There seems to be some overflow bugs in the size calculations. I + don't see how the size of 5g given in the example can actually work + on i386's. dd has a better size calculator that uses 64-bit arithmetic, + but it has overflow bugs too. Actually testing shows the not unexpected behaviour that 5g is silently truncated to 1g on i386's. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message