From owner-freebsd-ports  Sun Jun 11  8:45: 5 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from bsa-1-as01-7-a04.gd.uol.com.br (bsa-1-as01-7-a04.gd.uol.com.br [200.197.118.4])
	by hub.freebsd.org (Postfix) with ESMTP id EFE2837BF50
	for <freebsd-ports@FreeBSD.ORG>; Sun, 11 Jun 2000 08:45:01 -0700 (PDT)
	(envelope-from lioux@uol.com.br)
Received: (qmail 36744 invoked by uid 1001); 11 Jun 2000 15:45:07 -0000
From: lioux@uol.com.br
Date: Sun, 11 Jun 2000 12:45:07 -0300
To: "Mr. GTK+" <vanilla@play.cirx.org>
Cc: lioux@uol.com.br, freebsd-ports@FreeBSD.ORG
Subject: Re: ports/19193: Update textproc/jade to C{XX,}FLAGS safe status
Message-ID: <20000611124507.A36313@Fedaykin.here>
References: <20000611051106.74837.qmail@Fedaykin.here> <20000611133949.A75547@play.cirx.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20000611133949.A75547@play.cirx.org>; from vanilla@play.cirx.org on Sun, Jun 11, 2000 at 01:39:50PM +0800
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Sun, Jun 11, 2000 at 01:39:50PM +0800, Mr. GTK+ wrote:
> On Sun, Jun 11, 2000 at 05:11:06AM -0000, lioux@uol.com.br wrote:
> > Updated textproc/jade to C{XX,}FLAGS safe status.
> > Files removed:
> > 	patches/patch-aa
> > 
> > patch-aa is not necessary. "-O" is the default value for C{XX,}FLAGS.
> > I've just built jade 2 times using very weird C{XX,}FLAGS values
> > to be sure and it seems okay.
> > Besides, CONFIGURE_ENV is unusual. Just let CXXFLAGS be CXXFLAGS,
> > if the user has not set it, we do not unless it brakes the port
> > not to. This way we respect make.conf choices and behave safely in
> > possibly hostile enviroments (archs such as alpha).
> > jade behaves just fine without these
> Well, it the CFLAGS not set to '-O',
> it will dead on 'make release'...

	I did not know that. :)
	Could you add a comment line stating that?
	So that, no one submits additional PRs for that.

	Thanks,
		Mario Ferreira


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message