From owner-svn-src-all@freebsd.org  Mon Feb  8 21:42:39 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C079AA2392;
 Mon,  8 Feb 2016 21:42:39 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E26CA930;
 Mon,  8 Feb 2016 21:42:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id EC774B958;
 Mon,  8 Feb 2016 16:42:37 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Cc: Bryan Drewery <bdrewery@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r295226 - head/lib/libmemstat
Date: Mon, 08 Feb 2016 13:21:18 -0800
Message-ID: <12103176.kVCUAMSdl5@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <20160204170603.GF65294@FreeBSD.org>
References: <201602040023.u140NL0i052392@repo.freebsd.org>
 <56B29E36.8000900@FreeBSD.org> <20160204170603.GF65294@FreeBSD.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 08 Feb 2016 16:42:38 -0500 (EST)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Feb 2016 21:42:39 -0000

On Thursday, February 04, 2016 09:06:03 AM Gleb Smirnoff wrote:
> On Wed, Feb 03, 2016 at 04:41:26PM -0800, Bryan Drewery wrote:
> B> On 2/3/2016 4:23 PM, Gleb Smirnoff wrote:
> B> > Author: glebius
> B> > Date: Thu Feb  4 00:23:21 2016
> B> > New Revision: 295226
> B> > URL: https://svnweb.freebsd.org/changeset/base/295226
> B> > 
> B> > Log:
> B> >   Fix build.
> B> > 
> B> > Modified:
> B> >   head/lib/libmemstat/memstat_uma.c
> B> > 
> B> > Modified: head/lib/libmemstat/memstat_uma.c
> B> > ==============================================================================
> B> > --- head/lib/libmemstat/memstat_uma.c	Wed Feb  3 23:41:58 2016	(r295225)
> B> > +++ head/lib/libmemstat/memstat_uma.c	Thu Feb  4 00:23:21 2016	(r295226)
> B> > @@ -29,6 +29,7 @@
> B> >  #include <sys/param.h>
> B> >  #include <sys/cpuset.h>
> B> >  #include <sys/sysctl.h>
> B> > +#include <sys/_task.h>
> B> >  
> B> >  #include <vm/vm.h>
> B> >  #include <vm/vm_page.h>
> B> > 
> B> 
> B> Shouldn't uma_int.h forward declare or include _task.h for struct task?
> 
> Forward declaration won't work, since structure is included, not pointed at.
> I'm reluctant with adding includes into includes.

The sys/_foo.h headers are specifically designed so they can be used as nested
includes while (hopefully) introducing minimal pollution.  If you are embedding
struct task in a structure, use a nested include of <sys/_task.h>.  That is
why <sys/_task.h> exists as a separate header from <sys/taskqueue.h>.

-- 
John Baldwin