From owner-svn-ports-head@freebsd.org  Fri Jan 31 08:46:50 2020
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 481B8238A7E;
 Fri, 31 Jan 2020 08:46:50 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4889nQ0QvVz4JTk;
 Fri, 31 Jan 2020 08:46:50 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from localhost (16.55.62.188.dynamic.wline.res.cust.swisscom.ch
 [188.62.55.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: ehaupt)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 5C45A1A0DE;
 Fri, 31 Jan 2020 08:46:49 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Date: Fri, 31 Jan 2020 09:46:47 +0100
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r524645 - head/devel/py-construct
Message-Id: <20200131094647.9dcf772d804ce50765894189@FreeBSD.org>
In-Reply-To: <20200130230801.rdzwaqny7hlyxx32@atuin.in.mat.cc>
References: <202001301451.00UEpsDY022892@repo.freebsd.org>
 <20200130230801.rdzwaqny7hlyxx32@atuin.in.mat.cc>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jan 2020 08:46:50 -0000

Mathieu Arnold <mat@FreeBSD.org> wrote:
> On Thu, Jan 30, 2020 at 02:51:54PM +0000, Emanuel Haupt wrote:
> > Author: ehaupt
> > Date: Thu Jan 30 14:51:54 2020
> > New Revision: 524645
> > URL: https://svnweb.freebsd.org/changeset/ports/524645
> > 
> > Log:
> >   This port requires python 3.6 or later.
> >   
> >   Notified by:	pkg-fallout
> > 
> > Modified:
> >   head/devel/py-construct/Makefile
> >   head/devel/py-construct/distinfo
> > 
> > Modified: head/devel/py-construct/Makefile
> > ==============================================================================
> > --- head/devel/py-construct/Makefile	Thu Jan 30 14:45:47
> > 2020	(r524644) +++ head/devel/py-construct/Makefile
> > Thu Jan 30 14:51:54 2020	(r524645) @@ -15,7 +15,7 @@
> > LICENSE=	MIT LICENSE_FILE=	${WRKSRC}/LICENSE
> >  
> >  NO_ARCH=	yes
> > -USES=		python
> > +USES=		python:3.6+
> >  USE_PYTHON=	distutils autoplist
> 
> This broke security/py-trezor, which depends on this and has
> python:3.3+.
> 
> When you restrict the Python versions a port supports, you *must*
> check that all the ports that depend on it have the same
> restriction.  (And if you expand the Python versions, you have to
> check that its dependencies also support the same versions.)

I'll keep that in mind for the next time. Thank you for fixing py-trezor.

Emanuel