From owner-svn-ports-head@FreeBSD.ORG  Fri Sep 27 18:37:38 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 6A0F156D;
 Fri, 27 Sep 2013 18:37:38 +0000 (UTC) (envelope-from mva@FreeBSD.org)
Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de
 [80.67.29.28])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 225CE2329;
 Fri, 27 Sep 2013 18:37:37 +0000 (UTC)
Received: from [89.182.15.23] (helo=localhost)
 by smtprelay03.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256)
 (Exim 4.68) (envelope-from <mva@FreeBSD.org>)
 id 1VPcuB-0008GF-PC; Fri, 27 Sep 2013 20:36:44 +0200
Date: Fri, 27 Sep 2013 20:36:43 +0200
From: Marcus von Appen <mva@FreeBSD.org>
To: William Grzybowski <william88@gmail.com>
Subject: Re: svn commit: r328403 - head/Mk
Message-ID: <20130927183643.GA35802@medusa.sysfault.org>
Mail-Followup-To: William Grzybowski <william88@gmail.com>,
 ports-committers <ports-committers@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
References: <201309261827.r8QIR2Y8090911@svn.freebsd.org>
 <CAHtVNLPvWEO7bU1bUmc=gawB4HdytaTOosBR31V9JPBM_DYuyw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6"
Content-Disposition: inline
In-Reply-To: <CAHtVNLPvWEO7bU1bUmc=gawB4HdytaTOosBR31V9JPBM_DYuyw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Df-Sender: MTEyNTc0Mg==
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Marcus von Appen <mva@FreeBSD.org>
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Sep 2013 18:37:38 -0000


--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On, Thu Sep 26, 2013, William Grzybowski wrote:

[...]
> > +       { ${ECHO_CMD} "#mtree"; ${CAT} ${MTREE_FILE}; } | ${TAR} tf - | \
> > +               ${SED} '/^\.$$/d' > ${WRKDIR}/.localmtree
> > +       ${ECHO_CMD} "${_RELSITELIBDIR}" >> ${WRKDIR}/.localmtree
> > +       ${SED} 's|^${PREFIX}/||' ${_PYTHONPKGLIST} | ${SORT} >> ${TMPPLIST}
> > +       ${SED} -e 's|^${PREFIX}/\(.*\)/\(.*\)|\1|' ${_PYTHONPKGLIST} | \
> > +               while read line; do \
> > +                       ${GREP} -qw "^$${line}$$" ${WRKDIR}/.localmtree || { \
> > +                               [ -n "$${line}" ] && \
> > +                                       ${ECHO_CMD} "@unexec rmdir $${line} 2>/dev/null || true"; \
> > +                       }; \
> > +               done | ${SORT} | uniq | ${SORT} -r >> ${TMPPLIST}
>
> This logic iteration to find directories seems wrong.
> If I am not wrong and we have:
>
> dira/dirb/file1
> dira/dirc/file2
>
> And no files within dira/ it endes up removing dira/dirb/ and
> dira/dirc/, but not dira/.

Fixed, thanks for spotting this!

> Also, see this about enabling easy_install with AUTOPLIST and staging:
> http://people.freebsd.org/~wg/easyinstall-stage.txt

Working on it. I'm still a bit unsure about ports that do more complex
easy_install magic, so I'll try to get some of them properly tested
before committing your fix. Thanks!

Cheers
Marcus

--y0ulUmNC+osPPQO6
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)

iEYEARECAAYFAlJF0DoACgkQi68/ErJnpkeS0ACglaM3Nazs+4KBYEa7bV3HC+sN
gYgAoImfAVCfagrh7B5pd+r+5JM1ceYl
=6NuO
-----END PGP SIGNATURE-----

--y0ulUmNC+osPPQO6--