From owner-freebsd-current Tue Oct 1 8:12: 6 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAD1637B401 for ; Tue, 1 Oct 2002 08:12:04 -0700 (PDT) Received: from mail.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0CE7F43E6A for ; Tue, 1 Oct 2002 08:12:04 -0700 (PDT) (envelope-from eischen@pcnet1.pcnet.com) Received: from localhost (eischen@localhost) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id g91FC2r6020163; Tue, 1 Oct 2002 11:12:03 -0400 (EDT) Date: Tue, 1 Oct 2002 11:12:02 -0400 (EDT) From: Daniel Eischen To: Peter Wemm Cc: current@freebsd.org Subject: Re: Longer term fix for sigreturn ABI breaking In-Reply-To: <20020930230249.E57AF2A7D6@canning.wemm.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 30 Sep 2002, Peter Wemm wrote: > Daniel Eischen wrote: > > At the end is a potentially longer term fix for the ABI > > breakage that was introduced when the i386 mcontext_t > > was changed/enlarged. > > > - ret = set_fpcontext(td, &ucp->uc_mcontext); > > - if (ret != 0) > > - return (ret); > > + /* > > + * Intentionally ignore the error to keep binary > > + * compatibility with applications that fiddle with > > + * the FPU save area in the context. The kernel > > + * now saves the FPU state in the context, but it > > + * gets corrupted by those applications that try > > + * to work around the kernel NOT saving it. > > + */ > > + (void)set_fpcontext(td, &ucp->uc_mcontext); > > Maybe we could have something like this instead? > > ret = set_fpcontext(td, &ucp->uc_mcontext); > #if !defined(COMPAT_FREEBSD4) && !defined(COMPAT_43) > if (ret != 0) > return (ret); > #endif > > ie: ignore the error only if we have to be compatable. Sure that's totally doable. It might not be enough to just call set_fpcontext() and ignore the error. Thinking a bit more about it, the mc_len, mc_fpformat, and mc_ownedfp fields now occupy the first couple of slots where fpregs[] used to be. The format of an fnsave() stores the control, status and tag words in these slots. There are 32-bits of storage allocated for each of these, but the fnsave (according to what I see in npx.h), only uses the lower 16 bits. It might be possible to save a control word or status word that turn out to be valid for mc_fpformat or mc_ownedfp (0, 1, or 2). In this case we'd think the FP context was valid, and try to restore it (it would be trashed). I think if we put some magic in the upper 16 bits of mc_ownedfp, mc_fpformat, then we could prevent this. > Longer term, I was thining that we could/should do what sparc64 does, ie: > libc provides the trampoline and it can then call the correct sigreturn > syscall. That means we add a new sigreturn syscall each time we > significantly break the sigreturn ABI (as in this case) and applications > will be able to use the correct one. Paired with a new sigaction syscall > which would specify the "new" context format we can then be future proof. Sounds good. If we added a new sigaction and sigreturn now, we can still do the same thing, without having the trampoline in libc. I thought the point of having the trampoline in libc would prevent having to create new syscalls... -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message