From owner-freebsd-current@FreeBSD.ORG  Sun Apr 10 12:03:41 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D3A2416A4CE; Sun, 10 Apr 2005 12:03:41 +0000 (GMT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1B7A143D1D; Sun, 10 Apr 2005 12:03:41 +0000 (GMT)
	(envelope-from sos@DeepCore.dk)
Received: from [194.192.25.143] (laptop.deepcore.dk [194.192.25.143])
	by spider.deepcore.dk (8.13.3/8.13.3) with ESMTP id j3AC3cX4015081;
	Sun, 10 Apr 2005 14:03:38 +0200 (CEST)
	(envelope-from sos@DeepCore.dk)
Message-ID: <425915B9.3000606@DeepCore.dk>
Date: Sun, 10 Apr 2005 14:02:01 +0200
From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@DeepCore.dk>
User-Agent: Mozilla Thunderbird 1.0 (X11/20050116)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Wiktor Niesiobedzki <bsd@w.evip.pl>
References: <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>
In-Reply-To: <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
X-mail-scanned: by DeepCore Virus & Spam killer v1.12
cc: current@FreeBSD.ORG
cc: sos@FreeBSD.ORG
Subject: Re: ATA MkIII - Hang after resume solution
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Apr 2005 12:03:41 -0000

Wiktor Niesiobedzki wrote:
> Hi,
>=20
> I think I found solution to the problem, that after MkIII disks does no=
t
> reinit. Solution is simple:
>=20
> --- /usr/src/sys/dev/ata/ata-pci.c      Fri Apr  8 11:37:47 2005
> +++ /tmp/ata-pci.c      Sun Apr 10 13:09:48 2005
> @@ -599,8 +599,8 @@
>      DEVMETHOD(device_attach,    ata_pcichannel_attach),
>      DEVMETHOD(device_detach,    ata_pcichannel_detach),
>      DEVMETHOD(device_shutdown,  bus_generic_shutdown),
> -    DEVMETHOD(device_suspend,   bus_generic_suspend),
> -    DEVMETHOD(device_resume,    bus_generic_resume),
> +    DEVMETHOD(device_suspend,   ata_suspend),
> +    DEVMETHOD(device_resume,    ata_resume),
> =20
>      /* ATA methods */
>      DEVMETHOD(ata_setmode,      ata_pcichannel_setmode),
>=20
> This is rollback of changes introduced by MkIII. After that change
> suspend/resume works again.
>=20
> Can anybody review this?

I'll look into this and try to find out when/how this got changed.
Looks like a good catch though! thanks!

--=20

-S=F8ren