Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Dec 2019 22:39:29 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r356210 - head/sys/nfs
Message-ID:  <201912302239.xBUMdTli021436@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rmacklem
Date: Mon Dec 30 22:39:29 2019
New Revision: 356210
URL: https://svnweb.freebsd.org/changeset/base/356210

Log:
  Add warning printf w.r.t. removal of sys/nfs/nfs_lock.c.
  
  The code in sys/nfs/nfs_lock.c has not been run by default since March 2008
  when it was replaced by the in kernel sys/nlm code.
  It uses Giant, so it needs to be removed before the FreeBSD 13 release.
  This will happen in a couple of months, since few if any users run
  the code anyhow and can easily switch to the default in kernel NFSLOCKD.

Modified:
  head/sys/nfs/nfs_lock.c

Modified: head/sys/nfs/nfs_lock.c
==============================================================================
--- head/sys/nfs/nfs_lock.c	Mon Dec 30 22:05:57 2019	(r356209)
+++ head/sys/nfs/nfs_lock.c	Mon Dec 30 22:39:29 2019	(r356210)
@@ -89,6 +89,8 @@ nfslock_open(struct cdev *dev, int oflags, int devtype
 {
 	int error;
 
+	printf("WARNING: uses Giant and will be removed before FreeBSD 13\n"
+	    "\tuse the kernel NFSLOCKD/nfslockd.ko\n");
 	error = priv_check(td, PRIV_NFS_LOCKD);
 	if (error)
 		return (error);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912302239.xBUMdTli021436>