From owner-cvs-src@FreeBSD.ORG Wed Apr 25 19:07:39 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2815816A40A for ; Wed, 25 Apr 2007 19:07:39 +0000 (UTC) (envelope-from ups@freebsd.org) Received: from smtpout05.prod.mesa1.secureserver.net (smtpout05-04.prod.mesa1.secureserver.net [64.202.165.221]) by mx1.freebsd.org (Postfix) with SMTP id AF98F13C480 for ; Wed, 25 Apr 2007 19:07:38 +0000 (UTC) (envelope-from ups@freebsd.org) Received: (qmail 28058 invoked from network); 25 Apr 2007 18:40:58 -0000 Received: from unknown (66.23.216.53) by smtpout05-04.prod.mesa1.secureserver.net (64.202.165.221) with ESMTP; 25 Apr 2007 18:40:58 -0000 Message-ID: <462FA0BC.8020207@freebsd.org> Date: Wed, 25 Apr 2007 14:41:00 -0400 From: Stephan Uphoff User-Agent: Thunderbird 1.5.0.10 (Macintosh/20070221) MIME-Version: 1.0 To: Yar Tikhiy References: <200704211417.l3LEHUKK078832@repoman.freebsd.org> <462A27CD.5090006@freebsd.org> <1177170852.32761.0.camel@localhost> <20070424091858.GA31094@comp.chem.msu.su> In-Reply-To: <20070424091858.GA31094@comp.chem.msu.su> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org, Coleman Kane Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2007 19:07:39 -0000 Yar Tikhiy wrote: > On Sat, Apr 21, 2007 at 09:54:12AM -0600, Coleman Kane wrote: > >> On Sat, 2007-04-21 at 17:03 +0200, Andre Oppermann wrote: >> >>> Stephan Uphoff wrote: >>> >>>> ups 2007-04-21 14:17:30 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/amd64/amd64 pmap.c >>>> sys/i386/i386 pmap.c >>>> Log: >>>> Modify TLB invalidation handling. >>>> >>>> Reviewed by: alc@, peter@ >>>> MFC after: 1 week >>>> >>> Could you be a bit more verbose what changed here and why it >>> was done? >>> >>> >> I agree. I would really like to know what the modification accomplishes. >> > > Alas, we don't live in an ideal world. If we did, our commit > messages would always follow the well-known guideline: > > 0. Tell the essence of the change. > 1. Give the reason for the change. > 2. Explain the change unless it's trivial. > > In the ideal world there are no NDAs :-) As planned I forced a commit with a better comment once I was able to. Thanks for your patients, Stephan