From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Nov 24 14:02:06 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B9E5B383
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 24 Nov 2014 14:02:06 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A19DE955
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 24 Nov 2014 14:02:06 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sAOE26EA066928
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 24 Nov 2014 14:02:06 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 195333] New: Inconsistent handling of ALL_TARGET,
 INSTALL_TARGET by options framework
Date: Mon, 24 Nov 2014 14:02:06 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Infrastructure
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: amdmi3@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-195333-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2014 14:02:06 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195333

            Bug ID: 195333
           Summary: Inconsistent handling of ALL_TARGET, INSTALL_TARGET by
                    options framework
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Infrastructure
          Assignee: freebsd-ports-bugs@FreeBSD.org
          Reporter: amdmi3@FreeBSD.org

There's

ALL_TARGET?=        all
INSTALL_TARGET?=    install
INSTALL_TARGET+=    ${LATE_INSTALL_ARGS}

block in bsd.port.mk (line 2263), and it is located after bsd.options.mk
inclusion (line 1343). This leads to inconsistent handling of ALL_TARGET,
INSTALL_TARGET by options framework: while documentation and code suggest that

OPTIONS_DEFINE=FOO
FOO_ALL_TARGET=foo

should append foo to ALL_TARGET, it overrides ALL_TARGET instead.

If there are multiple options which define ${opt}_ALL_TARGET, first one will
override the variable and others will append.

To fix this, above mentioned block should be moved before bsd.options.mk
inclusion. Some ports may rely on old behavior, so they need to be checked.

-- 
You are receiving this mail because:
You are the assignee for the bug.