Date: Thu, 20 Apr 2000 12:05:42 +0200 From: Martin Cracauer <cracauer@cons.org> To: Anatoly Vorobey <mellon@pobox.com> Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/18104: missing include file in sh(1) Message-ID: <20000420120542.B14071@cons.org> In-Reply-To: <200004200400.VAA88954@freefall.freebsd.org>; from mellon@pobox.com on Wed, Apr 19, 2000 at 09:00:03PM -0700 References: <200004200400.VAA88954@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In <200004200400.VAA88954@freefall.freebsd.org>, Anatoly Vorobey wrote: > The following reply was made to PR bin/18104; it has been noted by GNATS. > > From: Anatoly Vorobey <mellon@pobox.com> > To: FreeBSD-gnats-submit@FreeBSD.ORG > Cc: > Subject: Re: bin/18104: missing include file in sh(1) > Date: Thu, 20 Apr 2000 06:55:33 +0000 > > > When sh(1) is compiled with DEBUG defined, as it usually isn't, > > show.c won't compile as it uses errno but lacks the include. > > The offending function, opentrace(), is inside a #ifdef DEBUG block. > > I've goofed here, in fact; sh(1) still won't build with DEBUG since -- > get that! -- the function trace() defined in show.c conflicts with > trace() in lib_trace.o of libtermcap.a of ncurses fame. > > I've renamed the sh function, and retested everything. When build with > DEBUG_FLAGS=-DDEBUG=2 , it'll create a file 'trace' in the current > directory and will write tons of good info there. Would someone please > review/commit? For me, it builds and writes to ./trace even without renaming trace(). It appears that the ncurses trace() hijacks your sh-internal trace where it should not and does not for me. I'm also not sure why you refer to DEBUG_FLAGS, maybe you use a non-standard build structure? What does nm -A *.o | grep trace show in your build directory? Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer@cons.org> http://www.cons.org/cracauer/ Tel.: (private) +4940 5221829 Fax.: (private) +4940 5228536 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000420120542.B14071>