From owner-dev-commits-src-main@freebsd.org Tue Jan 5 16:22:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A60554C1ADB; Tue, 5 Jan 2021 16:22:34 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D9HpL0zPYz4hMM; Tue, 5 Jan 2021 16:22:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1609863745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5snnol3RTLLij0OIeoN1RJziz4tJ28j/P5fwDL01n40=; b=qwcndofzr9MjdHpn1dsN2/AFYX3cmcbPAPGofJMNJnsLh0XFNSKAhqO+GDc56yzh/C44V/ 2huyjl+ZFLu+z1Ha4ZglTFfC7NbDMKADoZ+qGDZtEltwkEP5izqGEGubikXKEaQsaMbeW8 +00RDORowZ/YVJhqrFEEijB/60LMGwA= Received: from skull.home.blih.net (lfbn-idf2-1-745-114.w86-247.abo.wanadoo.fr [86.247.192.114]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 586b2b34 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 5 Jan 2021 16:22:25 +0000 (UTC) Date: Tue, 5 Jan 2021 17:22:22 +0100 From: Emmanuel Vadot To: rgrimes@freebsd.org Cc: "Rodney W. Grimes" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2d486ba15f33 - main - pkgbase: Move bectl to the runtime package Message-Id: <20210105172222.f967fd57a637287a1a3d778a@bidouilliste.com> In-Reply-To: <202101051554.105FsFL7008161@gndrsh.dnsmgr.net> References: <20210104220959.fb00d9ec75b43c3ed580ae37@bidouilliste.com> <202101051554.105FsFL7008161@gndrsh.dnsmgr.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4D9HpL0zPYz4hMM X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 16:22:34 -0000 On Tue, 5 Jan 2021 07:54:15 -0800 (PST) "Rodney W. Grimes" wrote: > > On Mon, 4 Jan 2021 12:58:58 -0800 (PST) > > "Rodney W. Grimes" wrote: > > > > > > On Mon, 4 Jan 2021 12:49:19 -0800 (PST) > > > > "Rodney W. Grimes" wrote: > > > > > > > > > > The branch main has been updated by manu: > > > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d486ba15f3367072d631ee588192ef46687fa4b > > > > > > > > > > > > commit 2d486ba15f3367072d631ee588192ef46687fa4b > > > > > > Author: Emmanuel Vadot > > > > > > AuthorDate: 2020-12-21 15:00:02 +0000 > > > > > > Commit: Emmanuel Vadot > > > > > > CommitDate: 2021-01-04 15:17:12 +0000 > > > > > > > > > > > > pkgbase: Move bectl to the runtime package > > > > > > > > > > > > runtime contain what is needed to boot in single user and repair a > > > > > > system, bectl could be handy to have in this situation. > > > > > > > > > > I would think it belongs in the zfs package, > > > > > as unless you have zfs you do not need bectrl. > > > > > > > > There is no zfs package. > > > > > > I would consider that an oversight. > > > > I don't. We don't have a ufs package for example. > > My understanding of the "big idea" of pkg base is to fine > grain feature install/removal, and I would consider support > for things like nfs, ufs, zfs to be along those lines > of fine grain. There is some limit to the fine grain. We started like that and we had 900+ packages, a lot of people didn't liked that. We're now at 293 packages (68 if you don't count the -dbg, -dev, -lib32 which won't be installed on most user machines). We still split part of the system into packages and I think that putting all the nfs tools might be a good idea (the same is true for a lot of binaries/libs present in the utilities package and a bit for some in the runtime one). > > > > > > Having zfs is controlled by WITH/WITHOUT_ZFS and this is not related > > > > to pkgbase. > > > > > > WITH/WITHOUT are compile time constructs, pkgbase is an install time > > > set of tools, why can there not be a zfs pkg? > > > > pkgbase is just a reflection of what is built. There can be a zfs > > package nothing prevent us for having one. But as said in the commit > > Great, then why dont we? And to your "ufs" above could that be > added as well? I don't think that having those binaries in their own package adds some advantages, even worse I think it's bad from a user point of view. There is honestly more important work to do for pkgbase than arguing about which packages should contain which files. I suggest you try pkgbase and see what you don't like about the organization and send a mail to pkgbase@f.o after. Cheers, > > runtime is the package that should contain everything needed for > > booting to single user and repair a system so it contain zfs related > > tools (and ufs ones). > > I thought the runtime package was the bits you MUST have to > build a running system, and nothing more. Perhaps I have > misunderstood. > > > > The idea behind runtime is that if you start upgrading and things > > break just after it you have all the tools to repair an install. > > I would of called that the "systemrepair" package. > > > > > > > > > > > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D27708 > > > > > > --- > > > > > > lib/libbe/Makefile | 1 + > > > > > > sbin/bectl/Makefile | 1 + > > > > > > 2 files changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/lib/libbe/Makefile b/lib/libbe/Makefile > > > > > > index 291e2438ee2a..d1fab41578bf 100644 > > > > > > --- a/lib/libbe/Makefile > > > > > > +++ b/lib/libbe/Makefile > > > > > > @@ -4,6 +4,7 @@ SHLIBDIR?= /lib > > > > > > > > > > > > .include > > > > > > > > > > > > +PACKAGE= runtime > > > > > > LIB= be > > > > > > SHLIB_MAJOR= 1 > > > > > > SHLIB_MINOR= 0 > > > > > > diff --git a/sbin/bectl/Makefile b/sbin/bectl/Makefile > > > > > > index 6fa84f48661d..46d43306b9ca 100644 > > > > > > --- a/sbin/bectl/Makefile > > > > > > +++ b/sbin/bectl/Makefile > > > > > > @@ -2,6 +2,7 @@ > > > > > > > > > > > > .include > > > > > > > > > > > > +PACKAGE=runtime > > > > > > PROG= bectl > > > > > > MAN= bectl.8 > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Rod Grimes rgrimes@freebsd.org > > > > > > > > > > > > -- > > > > Emmanuel Vadot > > > > > > > > > > -- > > > Rod Grimes rgrimes@freebsd.org > > > > > > -- > > Emmanuel Vadot > > > > -- > Rod Grimes rgrimes@freebsd.org -- Emmanuel Vadot