From owner-freebsd-audit Sun Mar 4 5: 6:59 2001 Delivered-To: freebsd-audit@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-158.dsl.lsan03.pacbell.net [63.207.60.158]) by hub.freebsd.org (Postfix) with ESMTP id E886937B71A; Sun, 4 Mar 2001 05:06:55 -0800 (PST) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 815C366B09; Sun, 4 Mar 2001 05:06:55 -0800 (PST) Date: Sun, 4 Mar 2001 05:06:55 -0800 From: Kris Kennaway To: Dag-Erling Smorgrav Cc: audit@FreeBSD.ORG, bde@FreeBSD.ORG Subject: Re: -Wnon-const-format patches, Pt 1 Message-ID: <20010304050655.A32634@mollari.cthul.hu> References: <20010303151334.A33979@mollari.cthul.hu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from des@ofug.org on Sun, Mar 04, 2001 at 02:03:34PM +0100 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 04, 2001 at 02:03:34PM +0100, Dag-Erling Smorgrav wrote: > Kris Kennaway writes: > > These are the patches I have so far for format string warnings with > > -Wnon-const-format, covering the bin/ tree. Please review (especially > > whether I've got all the __printflike/__printf0like attributes correct > > -- the difference being whether the function gracefully handles a NULL > > format string, like the err() family, or through explicit checks). >=20 > How about defining a wrapper macro for __printflike() that's empty > except when compiling with GCC? I know there are other issues that > prevent us from building our sources with other compilers, but there's > no reason to add yet another. __printflike/__printf0like is already a macro - see Kris --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6oj3uWry0BWjoQKURAhbuAJ9BFXmArB7NN9+f4y+akaRYYU1l1gCfXrh0 45su+8TEONE4/IbG5jT2CZQ= =f0om -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message