From owner-freebsd-current@FreeBSD.ORG Thu Apr 15 13:41:31 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE35B106564A; Thu, 15 Apr 2010 13:41:31 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from argol.doit.wisc.edu (argol.doit.wisc.edu [144.92.197.212]) by mx1.freebsd.org (Postfix) with ESMTP id 8E36B8FC16; Thu, 15 Apr 2010 13:41:31 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0L0X005027CVY200@smtpauth3.wiscmail.wisc.edu>; Thu, 15 Apr 2010 08:41:19 -0500 (CDT) Received: from comporellon.tachypleus.net ([unknown] [76.210.66.137]) by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0L0X00MUM7COW060@smtpauth3.wiscmail.wisc.edu>; Thu, 15 Apr 2010 08:41:13 -0500 (CDT) Date: Thu, 15 Apr 2010 08:41:12 -0500 From: Nathan Whitehorn In-reply-to: <201004150913.50097.jhb@freebsd.org> To: John Baldwin Message-id: <4BC71778.40505@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.210.66.137 X-Spam-PmxInfo: Server=avs-12, Version=5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2010.4.15.133316, SenderIP=76.210.66.137 References: <20100312171758.GB31089@dragon.NUXI.org> <201004071549.41672.jhb@freebsd.org> <201004150913.50097.jhb@freebsd.org> User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.9) Gecko/20100407 Thunderbird/3.0.4 Cc: pluknet , freebsd-current@freebsd.org Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2010 13:41:31 -0000 On 04/15/10 08:13, John Baldwin wrote: > On Thursday 15 April 2010 6:06:24 am pluknet wrote: > >> On 7 April 2010 23:49, John Baldwin wrote: >> >>> On Tuesday 06 April 2010 11:24:21 am Nathan Whitehorn wrote: >>> >>>> pluknet wrote: >>>> >>>>> Hi, >>>>> >>>>> the interesting part for me is how to properly assert now a value of >>>>> > e.g. > >>>>> KINFO_PROC_SIZE varying on err.. different COMPAT_FREEBSD32 arches >>>>> (say, FreeBSD would have _kern_proc FreeBSD32 compat layer for >>>>> > top/ps/). > >>>>> >>>>> >>>> Probably the cleanest thing would be to set KINFO_PROC_SIZE in >>>> machine/proc.h instead of where it is now, and then also define a >>>> KINFO_PROC32_SIZE or something in the same place. Also, that would be a >>>> really nice feature. >>>> >>> Yes, I think this sounds like the best approach. >>> >>> >> Something quick& not clean (well, it passes universe) attached. >> So, don't shoot me, please ;-). >> It's unclear how to convert those mips o32/n32/o64/n64 though. >> I had to make definitions out of _KERNEL visibility as far as >> is included from in !_KERNEL only too. >> > Just one suggestion: don't make KINFO_PROC32 #define depenedent on > COMPAT_FREEBSD32. It should just be always defined. I think that is the > approach Nathan used for the 32-bit ELF machine type. > I agree. There's no harm in making it a global definition. You also need a KINFO_PROC32 for ia64, which also implements i386 compatibility. Other than that, the patch looks good to me. -Nathan