From nobody Tue Apr 29 18:30:40 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zn85G0Vwlz5vMsy; Tue, 29 Apr 2025 18:30:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zn85F2cvcz4HVY; Tue, 29 Apr 2025 18:30:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745951441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rF0XgVtkphI0EwnoxHSn1+shMf0mTDS7DAcSc/G0Rp8=; b=fFoBpLICiI4OdiO0p3NcUsxexTOLYw4DD3VnbEBiLKhsJjFWKZ3JzKJg8VQnUDj1tnT1yE WIwWI+dideoWl7uQ+VlAFSPLk1CZO6hlSFfp95gnrVTIk7wGXjRBLxhAMVDrmsIkDerjGZ rOy1cK3EyQlM8wxlOIoGnOqC9eLZUgyGOR/RAy4DtrAKg0U0iqmFP0lTRT482KLdTENIgZ LgWytzDP3WnAUlPAgL3l5okXgk9ciLNvclzNEEBZB6kCV2MHFVti10ikrff/b/GxTpg3+5 GjScBTID8wFWfFysJ1jCcE4Pmoju+hehzNvatjMZfIWA3Ju9lkblRGPrld72aw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745951441; a=rsa-sha256; cv=none; b=cy2HivsIshO0WAKPDqet1gS8tXbKHO4NcWWuOvryB5O+pJj4lbIPT45CAQADMnQKu93OHt 9V7UsFLxjsOGXTZ2Ig6EhZle4LnJbdCJQYTQbobSdvrQKJ7FhCwU5/jBUtsCP8voF+TjJ/ g6hlSa7sDPhzO6pEta43mCW6J4/Thbp8OjfvsPgVpcOpPEbCphZ5f13MDCpPOVMQ/A4ORW GwpG337TqPaDHNJNo63y+bsCRmStdpekembvSuWgiQ7YJ+yLJa1nnDgnaBhgo9GsPuHcg5 r+QriUqfvKVPWVmg1CIoQ0YKh9/0Ol2K0S093dclcMKglsgT8qpcadb6zlNG3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745951441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rF0XgVtkphI0EwnoxHSn1+shMf0mTDS7DAcSc/G0Rp8=; b=jZe0Eev/HIvBzDRLvr/N6GPffJ5RvdYtdUGa3irDaz+G7jjGXmAhGaYeDm8GnXzbtXSf2L s6URtI/Ocd/JCgwwxm6S+7SUK6uNhqS5eoWL9rpiStPG8zy9IfW/7NRY963spIA89CZvpC VNsqclCHRsGfCikitFzcVB0RSGB3lLiqX5knoJ3m3alP6jvfcyUT1V6JBTmM1l+YRiZbpn aMX9LyBUO+Xscu8XvFGx8lfswiU9ZXnqxiiRl0WI+EIgYY97fl6XJ1Hag/dA72CK6z/ftO e/Sf5MZW3pHYu2l+BbLHKpg6axr6F5Rb71o2Z14aHZ4YDv8Nyh+YD5LfQ+gEaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zn85F0S8FzXQP; Tue, 29 Apr 2025 18:30:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53TIUeSH022663; Tue, 29 Apr 2025 18:30:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53TIUeHs022660; Tue, 29 Apr 2025 18:30:40 GMT (envelope-from git) Date: Tue, 29 Apr 2025 18:30:40 GMT Message-Id: <202504291830.53TIUeHs022660@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: ab9e7d209ac5 - stable/14 - hdaa: Don't hold a mutex while creating child devices List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ab9e7d209ac58e9c4d0a0ebd4bdb6f96f303e8df Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ab9e7d209ac58e9c4d0a0ebd4bdb6f96f303e8df commit ab9e7d209ac58e9c4d0a0ebd4bdb6f96f303e8df Author: John Baldwin AuthorDate: 2025-03-10 17:34:07 +0000 Commit: John Baldwin CommitDate: 2025-04-29 14:42:56 +0000 hdaa: Don't hold a mutex while creating child devices The lock is already not held while deleting child devices, and the bus_topo_lock is already held when child devices are created. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D49272 (cherry picked from commit 02d61f27585f52d422fc1e235ac6226e27145162) --- sys/dev/sound/pci/hda/hdaa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c index 3220ef69776b..14306526a4e7 100644 --- a/sys/dev/sound/pci/hda/hdaa.c +++ b/sys/dev/sound/pci/hda/hdaa.c @@ -6200,7 +6200,9 @@ hdaa_configure(device_t dev) HDA_BOOTHVERBOSE( device_printf(dev, "Creating PCM devices...\n"); ); + hdaa_unlock(devinfo); hdaa_create_pcms(devinfo); + hdaa_lock(devinfo); HDA_BOOTVERBOSE( if (devinfo->quirks != 0) {