From owner-cvs-all@FreeBSD.ORG Mon Jul 4 01:30:58 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA46B16A41C for ; Mon, 4 Jul 2005 01:30:58 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id A0B6243D45 for ; Mon, 4 Jul 2005 01:30:58 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by wproxy.gmail.com with SMTP id 40so259645wri for ; Sun, 03 Jul 2005 18:30:57 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Fz1S+srHL4uMbxMfeOwWJR3+CThu1wY3PymsKQe+dSigQYHYZBeSQI0vX1KdzwayGP0HfsDzo/1pLvi1443RyQaWuZX9He3su8AWGxn/HcbUSzQckakow6/K1kGOy6q87Tjg9z70Xl61SbhOZs5hIMC5gtxmYJX15TYq/BzWj7A= Received: by 10.54.59.7 with SMTP id h7mr914949wra; Sun, 03 Jul 2005 18:30:57 -0700 (PDT) Received: from michelle.rndsoft.co.kr ([211.32.202.209]) by mx.gmail.com with ESMTP id 10sm2636516wrl.2005.07.03.18.30.56; Sun, 03 Jul 2005 18:30:57 -0700 (PDT) Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) by michelle.rndsoft.co.kr (8.13.1/8.13.1) with ESMTP id j641TwGk001144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Jul 2005 10:29:58 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.1/8.13.1/Submit) id j641TrSi001143; Mon, 4 Jul 2005 10:29:53 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Date: Mon, 4 Jul 2005 10:29:53 +0900 From: Pyun YongHyeon To: Mike Silbersack Message-ID: <20050704012953.GA896@rndsoft.co.kr> References: <200507031824.j63IO3Bs009536@repoman.freebsd.org> <20050703184013.U21939@odysseus.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050703184013.U21939@odysseus.silby.com> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Andrew Thompson Subject: Re: cvs commit: src/sys/net bridge.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2005 01:30:59 -0000 On Sun, Jul 03, 2005 at 06:41:36PM -0500, Mike Silbersack wrote: > > On Sun, 3 Jul 2005, Andrew Thompson wrote: > > >thompsa 2005-07-03 18:24:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net bridge.c > > Log: > > Check the alignment of the IP header before passing the packet up to the > > packet filter. This would cause a panic on architectures that require > > strict > > alignment such as sparc64, ia64 and ppc. > > What's the route that a packet takes before it gets to the bridge? If it > goes through ether_input, it would make sense to put the alignment there > when necessary. > Agreed. > By the way, which network drivers are not aligning to the ip header right > now? > FYI: em(4) produces non-aligned ip header when it is configured to use JUMBO frames. This is the reason why em(4) does not work on strict alignment architectures. In addition em(4) should remove its use of inl/outl in order to work on sparc64/ppc etc. -- Regards, Pyun YongHyeon