From owner-freebsd-arm@FreeBSD.ORG Tue Jul 20 00:11:39 2010 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2ADE2106566B for ; Tue, 20 Jul 2010 00:11:39 +0000 (UTC) (envelope-from yohanes@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E86808FC12 for ; Tue, 20 Jul 2010 00:11:38 +0000 (UTC) Received: by iwn35 with SMTP id 35so6522032iwn.13 for ; Mon, 19 Jul 2010 17:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=joH9236obWsa1+8ZvVhAytZp4z65HshS2myNQYT8h50=; b=vWexPwDSp9pvKfCzr+7UGnWXq1TtIiWAIu0vG6DvEt7cZks9GW+Me/BXl6vH/kpTgp gpm9dwlUmY4xpNHfRvRLBvHUOYIn8ArJ5lUu9CsyfHrhfeiJYoR/M7y38mSUXh3rYlLl 9P6Ehxg+5SXoSmuN+A/Q18ghZDJ6Vw4gpAIf4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=bmGzttjcSy/Sap06ib5m82x2JhkSbQqc8yRXvMpXlIkAvAh5VVNpkg+cImK1tHhhaQ QEXWSkjIRBH6deOBSJP0xWfM6QE+lRiUqI3OkrCDOmKhF2TKETC/FhcvrLwhi2W3/zuh n0MHGGcGjjpPJg2/JmlT7M/plcvJE29EXExTg= Received: by 10.231.170.79 with SMTP id c15mr6285980ibz.82.1279584698130; Mon, 19 Jul 2010 17:11:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.19.197 with HTTP; Mon, 19 Jul 2010 17:11:18 -0700 (PDT) In-Reply-To: <20100719153614.GI28908@cicely7.cicely.de> References: <4C444E8B.6090104@ansley.com> <20100719153614.GI28908@cicely7.cicely.de> From: Yohanes Nugroho Date: Tue, 20 Jul 2010 07:11:18 +0700 Message-ID: To: ticso@cicely.de Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-arm@freebsd.org Subject: Re: at91sam9g20: Upcoming Patches X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 00:11:39 -0000 On Mon, Jul 19, 2010 at 10:36 PM, Bernd Walter wr= ote: >> if_ate.c: >> >> =C2=A0 =C2=A0* Support for sam9 "EMAC" controller. >> =C2=A0 =C2=A0* Support for rmii interface to phy. > > RM9200 ate requires specific DMA alignment, which required a few > realign copys. > This isn't neccessary for most other AT91 devices and for sure > not with any AT91SAM9x device. > Not sure if all of them are automatically avoided - you might want > to verify the code about this point. > There is also RBNA workaround, which should be RM9200 specifc, > which shouldn't be triggered with others, but you might want to save > a few bytes codespace. And looking at Linux's code, they separate for the RM9200 driver and newer AT9 (macb) drivers. I haven't looked deeply, but it seems that if we are going to support all variations of RM9200 PHY for link checking purpose, there will a lot of RM9200 specific code. I agree that there are many things in common between these two drivers, but I don't know if it is a good idea to keep everything in one file. --=20 Regards Yohanes http://yohan.es/