From owner-freebsd-current Thu Nov 11 18: 3:12 1999 Delivered-To: freebsd-current@freebsd.org Received: from alcanet.com.au (border.alcanet.com.au [203.62.196.10]) by hub.freebsd.org (Postfix) with ESMTP id 776EE14FD4 for ; Thu, 11 Nov 1999 18:03:06 -0800 (PST) (envelope-from jeremyp@gsmx07.alcatel.com.au) Received: by border.alcanet.com.au id <40350>; Fri, 12 Nov 1999 12:56:53 +1100 Content-return: prohibited Date: Fri, 12 Nov 1999 13:02:46 +1100 From: Peter Jeremy Subject: Re: panic: nexus_setup_intr: NULL irq resource! In-reply-to: <199911120135.MAA21532@gizmo.internode.com.au> To: Mark Newton Cc: current@FreeBSD.ORG Reply-To: peter.jeremy@alcatel.com.au Message-Id: <99Nov12.125653est.40350@border.alcanet.com.au> MIME-version: 1.0 X-Mailer: Mutt 1.0pre3i Content-type: text/plain; charset=us-ascii References: <99Nov12.121756est.40354@border.alcanet.com.au> <199911120135.MAA21532@gizmo.internode.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 1999-Nov-12 12:35:01 +1100, Mark Newton wrote: >Peter Jeremy wrote: > > > I'm trying to enable a generic ISA multiport SIO card in -current from > > just before the signal changes and get presented with the above panic > > when the first SIO port on the card is attached. > >Well... the first port that doesn't mention an IRQ. I can't recall right now whether the panic occurred with sio3 or sio4 when sio3 was master (and had an interrupt). >The problem is that the BUS_SETUP_INTR() method for ISA seems to >absolutely require the specification of an IRQ, even though IRQ >specification is absolutely prohibited for non-master ports in >AST-compatible multi-port sio cards. Gah. That's what the code looked like to me as well. Since multi-port SIO cards are supported, but will not have interrupts for the slave ports, I assumed I was missing something in the maze of nested, indirect function calls :-). As an aside, why doesn't our SIO driver work with ports that don't have interrupts? >I'm not completely sure that this patch does the right thing Since your patch effectively turns isa_setup_intr() into a nop for this case, a better patch would seem to be to skip the call to BUS_SETUP_INTR() (and presumably bus_alloc_resource()) at the end of sioattach() when you're attaching a slave SIO port. Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message