From owner-freebsd-net@FreeBSD.ORG Sun Nov 17 02:41:58 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 14629367 for ; Sun, 17 Nov 2013 02:41:58 +0000 (UTC) Received: from mail-qa0-x22f.google.com (mail-qa0-x22f.google.com [IPv6:2607:f8b0:400d:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C71BF2242 for ; Sun, 17 Nov 2013 02:41:57 +0000 (UTC) Received: by mail-qa0-f47.google.com with SMTP id w8so1475300qac.6 for ; Sat, 16 Nov 2013 18:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=WoCiCr8hycsesN6L6hTSIIfPmtIMZj+fIBsID3kZOQc=; b=GAKUNum6qdD5dKC3+Q45bDWulQovIvUuY8P53jg/p+YVLXspAMBvAabUMTZOZJNd9k TFuiJVrYaaswWPwrzJ1K+ki0cSyfO/XGsRMTncTLl4UgFYocV8FeAEMUSS0+Obv1kYDL 8HAFnu0R0/F91XkKviHc9J3j6sOgV4Os/28Wk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=WoCiCr8hycsesN6L6hTSIIfPmtIMZj+fIBsID3kZOQc=; b=QMoDaOqXiCd3iFH9JUWqwxISi67+Mz6tUtYL4lInq1rAKnrkMi6u45Q2Nq+h7FbgAF 3myBzlEcKp8q4A4oio8u4QdJ0Gc7Vll0or8oZ7VBAdIVu1UHy2GjV+t+qHeXHCNQAe3T 2/GGAf68SRTXGs36d6Gap6AInJ/1uc3cT58PrrpMcNIcWXufRa8vatlpe2GoBW406kt8 lH+zJfr4vA3UFV9mL9PLqybhpnrudHF5D8FFNr/IztDfAHejYHc2A0FDnovq2vwQSFvS YyNHSHihW7ZEi8toT/Pi1d+juO6KC0xfC3KBwbv3nO7VgGhU8HNisdjtpL2froULPVAH iYOw== X-Gm-Message-State: ALoCoQkTp+yVaKPclofxCQF2xL1O2W1d7QFVTBvZEIz/hP4vC7NA6S5xCNR82LK3kna7vh3E8K3b X-Received: by 10.224.131.67 with SMTP id w3mr23413630qas.62.1384656116781; Sat, 16 Nov 2013 18:41:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.63.101 with HTTP; Sat, 16 Nov 2013 18:41:26 -0800 (PST) In-Reply-To: <20131115165210.23f82578@stevek-ubuntu> References: <50F868FF.5060506@networx.ch> <20131115165210.23f82578@stevek-ubuntu> From: Eitan Adler Date: Sat, 16 Nov 2013 21:41:26 -0500 Message-ID: Subject: Re: [JNPR] Network stack as a module (RFC) To: Steve Kiernan Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-net@freebsd.org" , luigi@freebsd.org, Marcel Moolenaar , zec@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 02:41:58 -0000 On Fri, Nov 15, 2013 at 4:52 PM, Steve Kiernan wrote: > This is a follow up to the request sent back in January titled "Proposal for changes to network device drivers and network stack". > > In order to make it easier to review, we will be submitting pieces to be contributed in logical blocks. > > Please review the following patch and provide feedback: > http://people.freebsd.org/~marcel/Juniper/201311/netstack-option.diff There are a few empty #ifdef blocks: such as in sys/compat/svr4/svr4_proto.h +#ifdef NETSTACK +#else +#endif +#ifdef NETSTACK +#else +#endif +#ifdef NETSTACK +#else +#endif +#ifdef NETSTACK +#else +#endif Do we need these?