From owner-freebsd-bugs@FreeBSD.ORG  Mon Aug  4 23:30:18 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3E06337B401
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  4 Aug 2003 23:30:18 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DD33843F3F
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  4 Aug 2003 23:30:17 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h756UHUp037520
	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 4 Aug 2003 23:30:17 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h756UHVP037519;
	Mon, 4 Aug 2003 23:30:17 -0700 (PDT)
Date: Mon, 4 Aug 2003 23:30:17 -0700 (PDT)
Message-Id: <200308050630.h756UHVP037519@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: David Schultz <das@FreeBSD.ORG>
Subject: Re: bin/55124: [PATCH] request total incorrectly reported by
	vmstat(8)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: David Schultz <das@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Aug 2003 06:30:18 -0000

The following reply was made to PR bin/55124; it has been noted by GNATS.

From: David Schultz <das@FreeBSD.ORG>
To: Bruce M Simpson <bms@spc.org>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/55124: [PATCH] request total incorrectly reported by vmstat(8)
Date: Mon, 4 Aug 2003 23:23:23 -0700

 > 	Under RELENG_4, the running total of requests for each subsystem
 > 	client of the vm (vmstat -m) is incorrectly reported due to the use
 > 	of a signed (vs unsigned) integer.
 [...]
 > -	long totuse = 0, totfree = 0, totreq = 0;
 > +	long totuse = 0, totfree = 0;
 > +	unsigned long totreq = 0;
 
 This only buys you a factor of 2, then it overflows again.  totreq
 should be a uint64_t like the ks_calls values it's accumulating.