From owner-freebsd-java@FreeBSD.ORG  Wed Sep 24 04:02:35 2003
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0F31A16A4BF
	for <freebsd-java@FreeBSD.ORG>; Wed, 24 Sep 2003 04:02:35 -0700 (PDT)
Received: from puget.esil.univ-mrs.fr (puget.esil.univ-mrs.fr
	[139.124.41.103])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 86FEE44020
	for <freebsd-java@FreeBSD.ORG>; Wed, 24 Sep 2003 04:02:33 -0700 (PDT)
	(envelope-from rv@puget.esil.univ-mrs.fr)
Received: from puget.esil.univ-mrs.fr (localhost [127.0.0.1])
	h8OAqi9u013723;	Wed, 24 Sep 2003 12:52:45 +0200 (CEST)
	(envelope-from rv@puget.esil.univ-mrs.fr)
Received: (from rv@localhost)
	by puget.esil.univ-mrs.fr (8.12.9/8.12.9/Submit) id h8OAqirK013722;
	Wed, 24 Sep 2003 12:52:44 +0200 (CEST)
Date: Wed, 24 Sep 2003 12:52:44 +0200
From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: Ernst de Haan <ernst.dehaan@nl.wanadoo.com>
Message-ID: <20030924105244.GA12146@puget.esil.univ-mrs.fr>
References: <200309240954.45634.ernst.dehaan@nl.wanadoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200309240954.45634.ernst.dehaan@nl.wanadoo.com>
User-Agent: Mutt/1.4.1i
cc: freebsd-java@FreeBSD.ORG
Subject: Re: java/57142: unexhaustive check for installed linux jdk 1.4
	distributions in bsd.java.mk
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Sep 2003 11:02:35 -0000

On Wed, Sep 24, 2003 at 09:54:45AM +0200, Ernst de Haan wrote:
> Except for urgent fixes I won't make any changes to the bsd.java.mk file 
> until bsd.java.mk 2.0 is committed.
> 
> Herve, could you check if your bsd.java.mk 2.0 covers this issue?

I'll do that tonight.

At first check I realized a bug in bsd.java.mk 2.0 (a missing '-q' in
a grep). I've fixed this and a simple 'make java-debug' produces the
following output:

_USE_BSD_JAVA_MK_1_0= yes
_JAVA_PORTS_POSSIBLE= JAVA_PORT_FREEBSD_1_3 JAVA_PORT_FREEBSD_1_4 JAVA_PORT_LINUX_BLACKDOWN_1_3 JAVA_PORT_LINUX_BLACKDOWN_1_4 JAVA_PORT_LINUX_IBM_1_3 JAVA_PORT_LINUX_IBM_1_4 JAVA_PORT_LINUX_SUN_1_3 JAVA_PORT_LINUX_SUN_1_4
_JAVA_PORTS_INSTALLED= JAVA_PORT_FREEBSD_1_4 JAVA_PORT_LINUX_BLACKDOWN_1_3 JAVA_PORT_LINUX_BLACKDOWN_1_4
_JAVA_PORTS_INSTALLED_POSSIBLE= JAVA_PORT_FREEBSD_1_4 JAVA_PORT_LINUX_BLACKDOWN_1_3 JAVA_PORT_LINUX_BLACKDOWN_1_4
_JAVA_PORT= JAVA_PORT_FREEBSD_1_4
_JAVA_PORT_META= java/jdk14 /usr/local/jdk1.4.1 1.4 native FreeBSD
JAVA_PORT= java/jdk14
JAVA_HOME= /usr/local/jdk1.4.1
JAVA_PORT_VERSION= 1.4
JAVA_PORT_OS= native
JAVA_PORT_VENDOR= FreeBSD

So yes it handles this.

I've posted the fix:

http://www.esil.univ-mrs.fr/~hquiroz/bsd.java.mk-2.0-dev-20030924.tgz

Herve