From owner-freebsd-stable@freebsd.org Mon Jul 9 01:15:46 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C29DA102AD0B for ; Mon, 9 Jul 2018 01:15:46 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670083.outbound.protection.outlook.com [40.107.67.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 55320775AA for ; Mon, 9 Jul 2018 01:15:46 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM (52.132.44.24) by YTOPR0101MB1067.CANPRD01.PROD.OUTLOOK.COM (52.132.50.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Mon, 9 Jul 2018 01:15:44 +0000 Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::7098:a543:5be8:f30e]) by YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::7098:a543:5be8:f30e%4]) with mapi id 15.20.0930.016; Mon, 9 Jul 2018 01:15:44 +0000 From: Rick Macklem To: Daniel Engel , "freebsd-stable@freebsd.org" CC: NAGY Andreas Subject: Re: NFS 4.1 RECLAIM_COMPLETE FS failed error Thread-Topic: NFS 4.1 RECLAIM_COMPLETE FS failed error Thread-Index: AQHUFwfSZzACGjFgjkKGxIUROnrv0aSGEioz Date: Mon, 9 Jul 2018 01:15:44 +0000 Message-ID: References: <1531087387.2543270.1433935616.5272EA26@webmail.messagingengine.com> In-Reply-To: <1531087387.2543270.1433935616.5272EA26@webmail.messagingengine.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1067; 7:kR3X9Y1C+ETULHw9BLBaZPVE//i7zSKtSTa0xOay+BGO1Q/X5SInm54PYfXL+b2hOlcVIO+DYbRmyayowyg5IQaPDYsZhUezWXmN0jCpz9vxbaXxnGfknYapLVzZvLS1ltoyFUzRc0Cl9npvpNabBNVLqzEqtjC03ctpNQhb6yip2D7AGSEEndA3muOCocJh1eFOYAiC8jW/4yOYzg1MiLCj+xLwK0EVN/CJzHjDjjBIU/g/N0hBfRYEqK/UNtOl x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: d881895e-47b6-4ea7-d486-08d5e5397ef9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600053)(711020)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1067; x-ms-traffictypediagnostic: YTOPR0101MB1067: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(75325880899374); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:YTOPR0101MB1067; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1067; x-forefront-prvs: 07283408BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(366004)(346002)(396003)(189003)(199004)(53936002)(6246003)(5660300001)(33656002)(4326008)(316002)(786003)(229853002)(106356001)(14444005)(2501003)(256004)(105586002)(9686003)(6306002)(110136005)(55016002)(5250100002)(99286004)(6436002)(478600001)(97736004)(966005)(14454004)(2906002)(68736007)(19273905006)(74482002)(2900100001)(74316002)(6506007)(486006)(8936002)(26005)(476003)(102836004)(86362001)(7696005)(81166006)(76176011)(81156014)(305945005)(8676002)(11346002)(186003)(446003)(25786009)(563064011); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1067; H:YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: SaKetr9K3/SV84OdGhcaDPBAHz4bDg5SzI/KyqMp0VnkIzgRSPgsRkQ7gCLAl2Qb1FLAPj963kJW8N3C3yoR1PizHIwxe9wnUNDaylp55S7kBktwjhip7O/c9MVVuMULVWhHCyUkp6JSyVlT8+d33xyTsse4R+UssgdcIg95i87JbP3Mz9aPa21Lxld4VAXom++CO6SttOf2EEG4e2Sd65wKatB2Wgc14HN/dj30F2z5+GcU9aa+cQ5bFd+vl52TcVpsB1BCgQLp9ZzaAXyLB3LJDR9qVjXZFJ1nQ/V98NxNisFi0Hqqgx7wKQa4wpL1syQokWEajrz+hqpn3vVdy7xxlWqdqG53Ia1BfTIhiIU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: d881895e-47b6-4ea7-d486-08d5e5397ef9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2018 01:15:44.8366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1067 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 01:15:47 -0000 Daniel Engel wrote: >I am setting up an environment with FreeBSD 11.1 sharing a ZFS datastore t= o vmware >ESXI 6.7. There were a number of errors with NFS 4.1 sharing tha= t I didn't >understand until I found the following thread. > > > >I traced the commits that Rick has made since that thread and merged them = 'head' >into 'stable': > > 'svnlite checkout http://svn.freebsd.org/base/release/11.1.0/' > 'svnlite merge -c 332790 http://svn.freebsd.org/base/head' > 'svnlite merge -c 333508 http://svn.freebsd.org/base/head' > 'svnlite merge -c 333579 http://svn.freebsd.org/base/head' > 'svnlite merge -c 333580 http://svn.freebsd.org/base/head' > 'svnlite merge -c 333592 http://svn.freebsd.org/base/head' > 'svnlite merge -c 333645 http://svn.freebsd.org/base/head' > 'svnlite merge -c 333766 http://svn.freebsd.org/base/head' > 'svnlite merge -c 334396 http://svn.freebsd.org/base/head' > 'svnlite merge -c 334492 http://svn.freebsd.org/base/head' > 'svnlite merge -c 327674 http://svn.freebsd.org/base/head' > >That completely fixed the connection instability, but the NFS share was st= ill mounting >read-only with a RECLAIM_COMPLETE error. So, I manually appl= ied the first patch >from the previous thread and everything started workin= g: > > --- fs/nfsserver/nfs_nfsdserv.c.savrecl 2018-02-10 20:34:31.166445= 000 -0500 > +++ fs/nfsserver/nfs_nfsdserv.c 2018-02-10 20:36:07.947490000 -050= 0 > @@ -4226,10 +4226,9 @@ nfsrvd_reclaimcomplete(struct nfsrv_desc > goto nfsmout; > } > NFSM_DISSECT(tl, uint32_t *, NFSX_UNSIGNED); > + nd->nd_repstat =3D nfsrv_checkreclaimcomplete(nd); > if (*tl =3D=3D newnfs_true) > - nd->nd_repstat =3D NFSERR_NOTSUPP; > - else > - nd->nd_repstat =3D nfsrv_checkreclaimcomplete(nd); > + nd->nd_repstat =3D 0; > >The question is: Did I miss something? Is there an alternate change alrea= dy in SVN >that does the same thing better, or is there some corner case pr= eventing this patch >from being finalized that I just haven't run into yet? Andreas Nagy has been doing quite a bit of testing for me w.r.t the ESXi 6.= 5 client, but several serious issues (which appear to be violations of the RF= C to me) have not yet been resolved. This email summarizes then: http://docs.FreeBSD.org/cgi/mid.cgi?YTOPR0101MB0953E687D013E2E97873061ADD72= 0 He recently reported that 6.7 worked better, but he has not yet sent me any packet traces, so I don't know which issues still exist for 6.7. I have committed a few things that didn't break the RFC, such as adding BindConnectiontoSession, but I haven't committed anything else yet, due to concerns w.r.t. violating the RFC. (The above email thread discusses= that.) I do plan on doing something once I get packet traces from Andreas, but be forewarned that VMware states "FreeBSD is not a supported server" and that is certainly true. Andreas uses connection trunking. You might be ok with a single TCP connection unless the server reboots. (He runs a bunch of patches I gave him, some of which definitely violate the RFC.) All I can suggest is that you keep an eye on freebsd-current@ for any email about commits to handle the ESXi client better. So, this is very much a work in progress, rick