From owner-cvs-all@FreeBSD.ORG Mon Jul 4 01:32:46 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C3BE16A41C for ; Mon, 4 Jul 2005 01:32:46 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB47C43D49 for ; Mon, 4 Jul 2005 01:32:45 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by wproxy.gmail.com with SMTP id i25so623140wra for ; Sun, 03 Jul 2005 18:32:45 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=dMb0OFiAQNmOsqtf9lLXt4e20jYSb47LNSPH1C8fK2ykSH2hgS8dORbm+GDzuBQTq6nyn5PYqXDNk2Zk1zcxqsOk/umUreWK+EEOv5ixvmGkIsC93P2xPdpaY4xVf0cOQUnrDsa0N80FEe4Xxx4gXiQ6+UK3+1dmczxzevT+Mj0= Received: by 10.54.101.2 with SMTP id y2mr3362309wrb; Sun, 03 Jul 2005 18:32:45 -0700 (PDT) Received: from michelle.rndsoft.co.kr ([211.32.202.209]) by mx.gmail.com with ESMTP id 28sm3277037wrl.2005.07.03.18.32.43; Sun, 03 Jul 2005 18:32:45 -0700 (PDT) Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) by michelle.rndsoft.co.kr (8.13.1/8.13.1) with ESMTP id j641VkKM001164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Jul 2005 10:31:46 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.1/8.13.1/Submit) id j641VkvX001163; Mon, 4 Jul 2005 10:31:46 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Date: Mon, 4 Jul 2005 10:31:46 +0900 From: Pyun YongHyeon To: Andrew Thompson Message-ID: <20050704013146.GB896@rndsoft.co.kr> References: <200507031824.j63IO3Bs009536@repoman.freebsd.org> <20050703184013.U21939@odysseus.silby.com> <20050703235733.GA8138@heff.fud.org.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050703235733.GA8138@heff.fud.org.nz> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, Mike Silbersack , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bridge.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2005 01:32:46 -0000 On Mon, Jul 04, 2005 at 11:57:33AM +1200, Andrew Thompson wrote: > On Sun, Jul 03, 2005 at 06:41:36PM -0500, Mike Silbersack wrote: > > [...] > > > > What's the route that a packet takes before it gets to the bridge? If it > > goes through ether_input, it would make sense to put the alignment there > > when necessary. > > Both bridges tap their packets off near the end of ether_input(). Since > we only need to check alignment when using pfil(9) and each bridge has > its own knobs to control filtering, it seems best to leave it where it > is at the moment. > No, all protocol handlers should check alignment too. Normal code path without bridge/if_bridge would suffer from unaligned access. But I think your patch wouldn't hurt existing code. :-) -- Regards, Pyun YongHyeon