From owner-freebsd-fs@FreeBSD.ORG  Fri Jun 11 19:11:04 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EACAB1065674
	for <freebsd-fs@freebsd.org>; Fri, 11 Jun 2010 19:11:04 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200])
	by mx1.freebsd.org (Postfix) with ESMTP id 686688FC15
	for <freebsd-fs@freebsd.org>; Fri, 11 Jun 2010 19:11:03 +0000 (UTC)
Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua
	[10.1.1.148])
	by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o5BJB050036792
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 11 Jun 2010 22:11:00 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1])
	by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id
	o5BJB0N5060004; Fri, 11 Jun 2010 22:11:00 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
Received: (from kostik@localhost)
	by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o5BJAxAf060003; 
	Fri, 11 Jun 2010 22:10:59 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to
	kostikbel@gmail.com using -f
Date: Fri, 11 Jun 2010 22:10:59 +0300
From: Kostik Belousov <kostikbel@gmail.com>
To: Mikolaj Golub <to.my.trociny@gmail.com>
Message-ID: <20100611191059.GF13238@deviant.kiev.zoral.com.ua>
References: <86mxv22ji7.fsf@zhuzha.ua1>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="wtjvnLv0o8UUzur2"
Content-Disposition: inline
In-Reply-To: <86mxv22ji7.fsf@zhuzha.ua1>
User-Agent: Mutt/1.4.2.3i
X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua
X-Virus-Status: Clean
X-Spam-Status: No, score=-3.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DNS_FROM_OPENWHOIS autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	skuns.kiev.zoral.com.ua
Cc: freebsd-fs@freebsd.org
Subject: Re: '#ifndef DIAGNOSTIC' in nfsclient code looks like a typo
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2010 19:11:05 -0000


--wtjvnLv0o8UUzur2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 11, 2010 at 09:03:44AM +0300, Mikolaj Golub wrote:
> Hi:
>=20
> '#ifndef DIAGNOSTIC' in sys/nfsclient/nfs_vnops.c and
> sys/fs/nfsclient/nfs_clvnops.c looks like a typo and '#ifdef' should be u=
sed
> instead (see the attached patch).

All the changes should be converted to the KASSERTs. There is no point
in doing
	if (something)
		panic();
for diagnostic; use
	KASSERT(something, (panic message));


--wtjvnLv0o8UUzur2
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iEYEARECAAYFAkwSikMACgkQC3+MBN1Mb4ht8wCg4Lo/kk++XQFke4I56+CCH46v
O1cAnRHlBUAYSiDN3fKNYfxaT989cDOo
=qNG7
-----END PGP SIGNATURE-----

--wtjvnLv0o8UUzur2--