From owner-cvs-src@FreeBSD.ORG  Thu Sep 18 19:19:49 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 71ADC1065676;
	Thu, 18 Sep 2008 19:19:49 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 00AA18FC17;
	Thu, 18 Sep 2008 19:19:48 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id
	m8IJJl8V056297; Thu, 18 Sep 2008 21:19:47 +0200 (CEST)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.3/8.14.3/Submit) id m8IJJlhM056296;
	Thu, 18 Sep 2008 21:19:47 +0200 (CEST) (envelope-from marius)
Date: Thu, 18 Sep 2008 21:19:47 +0200
From: Marius Strobl <marius@alchemy.franken.de>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20080918191947.GX94638@alchemy.franken.de>
References: <200809181356.m8IDuaxT089888@repoman.freebsd.org>
	<200809181027.51997.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200809181027.51997.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/sparc64/include smp.h
	src/sys/sparc64/sparc64 genassym.c mp_machdep.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Sep 2008 19:19:49 -0000

On Thu, Sep 18, 2008 at 10:27:51AM -0400, John Baldwin wrote:
> On Thursday 18 September 2008 09:56:30 am Marius Strobl wrote:
> > marius      2008-09-18 13:56:30 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/sparc64/include  smp.h 
> >     sys/sparc64/sparc64  genassym.c mp_machdep.c 
> >   Log:
> >   SVN rev 183142 on 2008-09-18 13:56:30Z by marius
> >   
> >   - Newer firmware versions no longer provide SUNW,stop-self so just
> >     disable interrupts and loop forever with these.
> >   - Hide all MP-related bits in <machine/smp.h> underneath #ifdef SMP.
> >   - Inline ipi_all_but_self(9) and ipi_selected(9). We don't expose any
> >     additional bits but save a few cycles by doing so.
> >   - Remove ipi_all(9), which actually only called panic(9). It can't be
> >     implemented natively anyway and having it removed at least causes
> >     MI users to fail already fail when linking.
> 
> Should we just remove ipi_all() completely?
> 

Well, grepping in the CVS repository shows that there never was
an actually consumer of ipi_all() (only #ifdef'ed out ones in
ironically the sparc64 code) so it seems to be a good candidate
for axing. Generally I can't think of a reason why MI code would
want a CPU to send an IPI to itself. Actually, ipi_self() also
isn't and never was used in MI code, only in ia64 and powerpc
code for testing purposes.

Marius