Date: Thu, 10 Aug 2023 09:28:58 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernando.apesteguia@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+) Message-ID: <CAGwOe2YwVsgjd1GB4F7qQjpe9Hoq5LU3nve9FyWjU1Rb%2B5tkTw@mail.gmail.com> In-Reply-To: <ZNSNGjDjZZH48Juu@FreeBSD.org> References: <202308100620.37A6KIqg017783@gitrepo.freebsd.org> <CAGwOe2YTNpBO-aO5dCxKnHzy%2Bg=7D3n7JSQ9HD4vYKfYGuUZrA@mail.gmail.com> <ZNSNGjDjZZH48Juu@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000007cc44406028c8db6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023 at 9:09=E2=80=AFAM Alexey Dokuchaev <danfe@freebsd.org= > wrote: > On Thu, Aug 10, 2023 at 08:53:19AM +0200, Fernando Apestegu??a wrote: > > On Thu, Aug 10, 2023 at 8:20???AM Alexey Dokuchaev wrote: > > > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32 > > > > > > textproc/p5-excel2csv: new port had been added (+) > > > > > > Provides two scripts for converting Microsoft Excel > > > spreadsheet formats (both XLS and XLSX) to CSV. > > > > This project has seen only 4 commits since 2014 > > It's never had issues or pull request > > This often is an indication of a good, finished program. :) > Oh, in that case thank you for bringing the very first *perfect* piece of software to the ports tree. Wait... the last commit was on Jun 23rd 2021 and it was a fix... and the previous commit was in 2017. So it looks like the --file option was broken for at least 4 years. Maybe the lack of user interaction is not an indication of the perfection of the software after all. > > This smells suspicious as in "nobody uses this software". > > It could be valid observation, but then you should've asked Henrik > these questions, not closed PR as "fixed" when it's really not. > Should have been "Overcome by events", sorry. > > I've just used it to convert several *.xls and *.xlsx files created > with recent version of Excel and LibreOffice and it works fine, making > it useful at least for the original submitter and myself. > I didn't know "it is useful for the submitter" was an enough condition to add a new port. Thanks for the info. > > > The "parent" project in CPAN has only 3 issues. All of them unresolved > > for the last 7, 9 and 12 years > > The author mentions that CPAN version is behind GitHub's in the README > and so does the port in the description. > The critical issue is reported for version 1.07, the exact same version you just imported: https://rt.cpan.org/Public/Bug/Display.html?id=3D93327 Although maybe not. The port uses commit 49386af, yet 1.07 (the latest and only tag) is in 9c49bc6 Anyway thank you for the clarifications. I won't bother you with this anymore. > > ./danfe > --0000000000007cc44406028c8db6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Thu, Aug 10, 2023 at 9:09=E2=80=AF= AM Alexey Dokuchaev <<a href=3D"mailto:danfe@freebsd.org">danfe@freebsd.= org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"marg= in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e= x">On Thu, Aug 10, 2023 at 08:53:19AM +0200, Fernando Apestegu??a wrote:<br= > > On Thu, Aug 10, 2023 at 8:20???AM Alexey Dokuchaev wrote:<br> > > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32<br> > ><br> > >=C2=A0 =C2=A0textproc/p5-excel2csv: new port had been added (+)<br= > > ><br> > >=C2=A0 =C2=A0Provides two scripts for converting Microsoft Excel<b= r> > >=C2=A0 =C2=A0spreadsheet formats (both XLS and XLSX) to CSV.<br> > <br> > This project has seen only 4 commits since 2014<br> > It's never had issues or pull request<br> <br> This often is an indication of a good, finished program. :)<br></blockquote= ><br></div><div class=3D"gmail_quote">Oh, in that case thank you for bringi= ng the very first *perfect* piece of software to the ports tree.</div><div = class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">Wait... the last= commit was on Jun 23rd 2021 and it was a fix... and the previous commit wa= s in 2017.</div><div class=3D"gmail_quote">So it looks like the --file opti= on was broken for at least 4 years.<br></div><div class=3D"gmail_quote">May= be the lack of user interaction is not an indication of the perfection of t= he software after all.<br></div><div class=3D"gmail_quote"><div><br></div><= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> <br> > This smells suspicious as in "nobody uses this software".<br= > <br> It could be valid observation, but then you should've asked Henrik<br> these questions, not closed PR as "fixed" when it's really no= t.<br></blockquote><div><br></div><div>Should have been "Overcome by e= vents", sorry.<br></div><div>=C2=A0</div><blockquote class=3D"gmail_qu= ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20= 4);padding-left:1ex"> <br> I've just used it to convert several *.xls and *.xlsx files created<br> with recent version of Excel and LibreOffice and it works fine, making<br> it useful at least for the original submitter and myself.<br></blockquote><= div><br></div><div>I didn't know "it is useful for the submitter&q= uot; was an enough condition to add a new port.</div><div>Thanks for the in= fo.<br></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"ma= rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:= 1ex"> <br> > The "parent" project in CPAN has only 3 issues. All of them = unresolved<br> > for the last 7, 9 and 12 years<br> <br> The author mentions that CPAN version is behind GitHub's in the README<= br> and so does the port in the description.<br></blockquote><div><br></div><di= v>The critical issue is reported for version 1.07, the exact same version y= ou just imported: <a href=3D"https://rt.cpan.org/Public/Bug/Display.html?id= =3D93327">https://rt.cpan.org/Public/Bug/Display.html?id=3D93327</a></div><= div>Although maybe not. The port uses commit 49386af, yet 1.07 (the latest = and only tag) is in 9c49bc6</div><div><br></div><div>Anyway thank you for t= he clarifications.</div><div>I won't bother you with this anymore.<br><= /div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px= 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> ./danfe<br> </blockquote></div></div> --0000000000007cc44406028c8db6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YwVsgjd1GB4F7qQjpe9Hoq5LU3nve9FyWjU1Rb%2B5tkTw>