From owner-freebsd-toolchain@FreeBSD.ORG Mon Oct 17 17:30:41 2011 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F15C10656D8 for ; Mon, 17 Oct 2011 17:30:41 +0000 (UTC) (envelope-from rdivacky@vlakno.cz) Received: from vlakno.cz (lev.vlakno.cz [46.28.110.116]) by mx1.freebsd.org (Postfix) with ESMTP id C3FB88FC18 for ; Mon, 17 Oct 2011 17:30:40 +0000 (UTC) Received: by vlakno.cz (Postfix, from userid 1002) id 827FE7F383E; Mon, 17 Oct 2011 19:12:46 +0200 (CEST) Date: Mon, 17 Oct 2011 19:12:46 +0200 From: Roman Divacky To: Gerald Pfeifer Message-ID: <20111017171246.GA4161@freebsd.org> References: <20111017152548.GA66978@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-toolchain@freebsd.org Subject: Re: [toolchain] disable -Wtautological-compare for clang X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2011 17:30:41 -0000 On Mon, Oct 17, 2011 at 09:56:23AM -0700, Gerald Pfeifer wrote: > On Mon, 17 Oct 2011, Alexander Best wrote: > > any chance we could disable -Wtautological-compare for clang? i don't > > think comparing an unsigned int against < 0 is worth a warning. actually > > it's always nice to have such a seatbelt, in case somebody changes the > > type to int and forgets to introduce such a check. > > I am on the fence on this one, for when I used the equivalent warning > in GCC this did found a number of real issues that I then addressed for > Wine (as an example). I also think this warning is very useful. Even in the "< 0" case, just think of the case when one meant "> 0" but typed the opposite. roman