From owner-svn-ports-all@freebsd.org  Sun May 29 15:29:49 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F608B53B89;
 Sun, 29 May 2016 15:29:49 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 451A6121D;
 Sun, 29 May 2016 15:29:49 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 43BBB126A; Sun, 29 May 2016 15:29:49 +0000 (UTC)
Date: Sun, 29 May 2016 15:29:49 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r416053 - head/Mk/Uses
Message-ID: <20160529152949.GA88078@FreeBSD.org>
References: <201605281719.u4SHJiAa008852@repo.freebsd.org>
 <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc>
 <20160528200254.GI1036@fc.opsec.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160528200254.GI1036@fc.opsec.eu>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 May 2016 15:29:49 -0000

On Sat, May 28, 2016 at 10:02:55PM +0200, Kurt Jaeger wrote:
> > [...]
> > I should explain a bit more.
> > 
> > This goes against the Right Way Of Doing Things(c)(r)(tm).
> > 
> > To add a target to be run in the targets pipeline, you use _USES_xxx, you
> > never, ever, piggyback on an existing target, especially if you're not
> > using it.
> > 
> > So, please, back this out.
> 
> Done. I'm not sure *why* the kde folks requested this change
> in the first place, so I'll ask them.

In this case I'm even more puzzled: why commit a change that you don't fully
understand?  You should've asked them before committing, not after.

Writing proper commit messages also helps: lack of "why" clause (or inability
to come up with one) indicates that change is probably not committable yet.

./danfe