From nobody Sun Jun 14 22:32:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gdp0S1659z6hZQh for ; Sun, 14 Jun 2026 22:32:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gdp0S0YzVz3cF6 for ; Sun, 14 Jun 2026 22:32:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781476344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ld8mA6MXWKjA2KvNfvbRNkny1QJk4N+yk77K46OF6+o=; b=sajD3HnxtbRQS8fGRJAKftpsZE6hCBve8/5Xnft/I54W+fWupfxxbF9BMjypK12156xp0E 4QiSZD3WN+R5ISaOvhLGCY2yftqE8pnGtwbSU04ay+llWgyI7pIPRpb0pXCnugfaNXWuna DcGWyjbc+l/kkK2MxQxnjy/Rq5hSfLr8nuxV+vTcf6BcVNvrAiCVV0/EaLRpD+f8V4+4kS rSI3RoljRykGnE/ZuxzEHy7wZpMbiNZw+YUGZLm9En4018uJaFEjVb1qzvnV8S7IvOnavO Trgvz+lxwQtwmZgGtUqnBjgP009abcOF3B2CL7+7WLgyQ2MmsyzWS/XV4aw4Gw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781476344; a=rsa-sha256; cv=none; b=PpOxKqBck0FATp3i6J/HemfAMpF2sVn8oPuKE72j1KvdJaAB3gh6kM3n7CF6Agzn1HIIFC dj1nGs/iN0dNkLFgdovA0JA76BUE5YwDJB6FOSeEVUWK6hoN+yze5bVm1TdqDYzLbWi9kl 0/zEPjq2pgSf31ikp1xLyXCv4RhUvlsse0O8vluOX17PSfgyltE+XvaU598hYhFr6HTcHa Y0THlNEMqo4j/ube12E5dxC2rlEFUSm2kQ6IddNnwcnvK+73LOKG14JgoiZDHJ17CGU5K/ 24excjvFoiPFRKLVEOFOS5zyf/iscoQWUYIWufKPJYblHVPWX8XTTXAgFVSYzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781476344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ld8mA6MXWKjA2KvNfvbRNkny1QJk4N+yk77K46OF6+o=; b=ojuklwNF773iw5S2JOQa7O5vwj+nr4gPhI2xqHol2Yyw6ejIGOYOQvdYfwSlqLLOf/QqWN XfFBnkM0y4XtAr/byai1xoYsDu+y6LltrwnQReQBg49chBB21A/Q7tLbyzDrUhtr6u7Zfy OTVUHw6lv7PIi4mnwNWvDXWR4GlHLD7WyC2YasS7GxAtw1+S/alEl8Qc6C+NU1TaqERzRP EDclOu0/+OuDWbgvVMyy4mSFjTPzocpa7+lM3ocBwsINbS5H9BTzPf+FqL+bCgDsmhIc8M ZpNrxXdkf23FvzU6ExO+2dk0dv4XQKNzqmILB1l94+UVzKLwhVEqECEGJEfF5w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gdp0S05tLzCwY for ; Sun, 14 Jun 2026 22:32:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 414e5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 14 Jun 2026 22:32:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 0cb3b9229876 - main - LinuxKPI: 802.11: add print masks for tx status flags List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0cb3b9229876a2a83d217779cf5ecd09eb153fc3 Auto-Submitted: auto-generated Date: Sun, 14 Jun 2026 22:32:24 +0000 Message-Id: <6a2f2bf8.414e5.ae5cf84@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=0cb3b9229876a2a83d217779cf5ecd09eb153fc3 commit 0cb3b9229876a2a83d217779cf5ecd09eb153fc3 Author: Bjoern A. Zeeb AuthorDate: 2026-06-10 11:50:03 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-06-14 22:31:37 +0000 LinuxKPI: 802.11: add print masks for tx status flags Add print masks for tx status flags and use them in the TX tracing in order to more easily debug TX problems. As a result it was easier to determine that some dirver like the mt7921 (or mt76) do not always zero the status bits of the tx status information (it is a union with the control bits passed on TX) and thus we get bogus values back (rather than having flags in a different place than we thought). Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/compat/linuxkpi/common/include/linux/ieee80211.h | 11 +++++++++++ sys/compat/linuxkpi/common/src/linux_80211.c | 8 ++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/ieee80211.h b/sys/compat/linuxkpi/common/include/linux/ieee80211.h index b8f29560f200..dede010c57de 100644 --- a/sys/compat/linuxkpi/common/include/linux/ieee80211.h +++ b/sys/compat/linuxkpi/common/include/linux/ieee80211.h @@ -466,9 +466,20 @@ enum ieee80211_tx_info_flags { IEEE80211_TX_CTL_STBC = BIT(20), } __packed; +#define IEEE80211_TX_INFO_FLAGS \ + "\010\1CTL_AMPDU\2CTL_ASSIGN_SEQ\3CTL_NO_ACK\4CTL_SEND_AFTER_DTIM" \ + "\5CTL_TX_OFFCHAN\6CTL_REQ_TX_STATUS" \ + "\7STATUS_EOSP\10STAT_ACK\11STAT_AMPDU\12STAT_AMPDU_NO_BACK" \ + "\13STAT_TX_FILTERED\14STAT_NOACK_TRANSMITTED" \ + "\15CTL_FIRST_FRAGMENT\16INTFL_DONT_ENCRYPT\17CTL_NO_CCK_RATE" \ + "\20CTL_INJECTED\21CTL_HW_80211_ENCAP\22CTL_USE_MINRATE" \ + "\23CTL_RATE_CTRL_PROBE\24CTL_LDPC\25CTL_STBC" + enum ieee80211_tx_status_flags { IEEE80211_TX_STATUS_ACK_SIGNAL_VALID = BIT(0), }; +#define IEEE80211_TX_STATUS_FLAGS \ + "\010\1ACK_SIGNAL_VALID" enum ieee80211_tx_control_flags { /* XXX TODO .. right shift numbers */ diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 11f76c3ff5a5..280c8dbe176c 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -8804,13 +8804,13 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, #ifdef LINUXKPI_DEBUG_80211 if (linuxkpi_debug_80211 & D80211_TRACE_TX) - printf("TX-STATUS: %s: hw %p skb %p status %d : flags %#x " + printf("TX-STATUS: %s: hw %p skb %p status %d : flags %b " "band %u hw_queue %u tx_time_est %d : " "rates [ %u %u %#x, %u %u %#x, %u %u %#x, %u %u %#x ] " "ack_signal %u ampdu_ack_len %u ampdu_len %u antenna %u " - "tx_time %u flags %#x " + "tx_time %u flags %b " "status_driver_data [ %p %p ]\n", - __func__, hw, skb, status, info->flags, + __func__, hw, skb, status, info->flags, IEEE80211_TX_INFO_FLAGS, info->band, info->hw_queue, info->tx_time_est, info->status.rates[0].idx, info->status.rates[0].count, info->status.rates[0].flags, @@ -8822,7 +8822,7 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, info->status.rates[3].flags, info->status.ack_signal, info->status.ampdu_ack_len, info->status.ampdu_len, info->status.antenna, - info->status.tx_time, info->status.flags, + info->status.tx_time, info->status.flags, IEEE80211_TX_STATUS_FLAGS, info->status.status_driver_data[0], info->status.status_driver_data[1]); #endif