From owner-freebsd-net@FreeBSD.ORG  Wed Apr 16 06:52:01 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2F20E756;
 Wed, 16 Apr 2014 06:52:01 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id ABB3E159D;
 Wed, 16 Apr 2014 06:51:59 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.8/8.14.8) with ESMTP id s3G6pOR2036766
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 16 Apr 2014 10:51:24 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.8/8.14.8/Submit) id s3G6pOLk036765;
 Wed, 16 Apr 2014 10:51:24 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 16 Apr 2014 10:51:24 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Subject: Re: route(8) fix
Message-ID: <20140416065124.GZ902@glebius.int.ru>
References: <CFF66C95-C9A6-40F2-89B7-470BEDC8D91B@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CFF66C95-C9A6-40F2-89B7-470BEDC8D91B@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: FreeBSD Net <freebsd-net@freebsd.org>, Hiroki Sato <hrs@FreeBSD.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2014 06:52:01 -0000

On Tue, Apr 15, 2014 at 10:45:27PM +0000, Bjoern A. Zeeb wrote:
B> can someone please review the below patch and see if it’s correct?
B> I did a simple 1:1 replacement without thinking about the code.
B> 
B> ! When switching variables to flags in r243185 a few cases were missed.
B> ! After r263152 this leaves unused variables if route(8) is compiled
B> ! without INET support.
B> 
B> https://people.freebsd.org/~bz/20140415-01-sbin-route.diff

Looks entirely correct and probably should fix some bugs.

-- 
Totus tuus, Glebius.