From owner-freebsd-bugs@freebsd.org Tue Nov 10 21:29:49 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28478A2C38D for ; Tue, 10 Nov 2015 21:29:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 13E5E17DC for ; Tue, 10 Nov 2015 21:29:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tAALTmLf035808 for ; Tue, 10 Nov 2015 21:29:48 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 204097] witness_initialize() does not perform bound checking of witness_count Date: Tue, 10 Nov 2015 21:29:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bjk@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 21:29:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204097 Benjamin Kaduk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjk@FreeBSD.org --- Comment #1 from Benjamin Kaduk --- Changing 'i' to be of type size_t would be a more architecturally pleasing change, if a change is needed here. I see some argument for anti-foot-shooting here, but it is not a particularly strong one -- such a large value of witness_count seems unlikely to lead to a usable system anyway, so it is not reasonable for an administrator to want to set such a value. There are many, many ways in which tunables can be (ab)used to create a broken system and panics, and it's not reasonable to put in anti-foot-shooting measures for all of them, particularly the ones where there is not a reasonable reason to want to set such values in the first place. -- You are receiving this mail because: You are the assignee for the bug.