Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Nov 2015 21:29:49 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 204097] witness_initialize() does not perform bound checking of witness_count
Message-ID:  <bug-204097-8-a3xMGqQFA2@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204097-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-204097-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204097

Benjamin Kaduk <bjk@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bjk@FreeBSD.org

--- Comment #1 from Benjamin Kaduk <bjk@FreeBSD.org> ---
Changing 'i' to be of type size_t would be a more architecturally pleasing
change, if a change is needed here.

I see some argument for anti-foot-shooting here, but it is not a particularly
strong one -- such a large value of witness_count seems unlikely to lead to a
usable system anyway, so it is not reasonable for an administrator to want to
set such a value.  There are many, many ways in which tunables can be (ab)used
to create a broken system and panics, and it's not reasonable to put in
anti-foot-shooting measures for all of them, particularly the ones where there
is not a reasonable reason to want to set such values in the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204097-8-a3xMGqQFA2>