From owner-svn-ports-all@freebsd.org  Sat Aug 24 13:08:42 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id C0AC9DFCAF;
 Sat, 24 Aug 2019 13:08:42 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46Fz9Q4f5zz3DpQ;
 Sat, 24 Aug 2019 13:08:42 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 988F21E03D; Sat, 24 Aug 2019 13:08:42 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Piotr Kubaj <pkubaj@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r509720 - in head/lang/angelscript: . files
References: <201908241238.x7OCcuT1025093@repo.freebsd.org>
Date: Sat, 24 Aug 2019 15:08:37 +0200
In-Reply-To: <201908241238.x7OCcuT1025093@repo.freebsd.org> (Piotr Kubaj's
 message of "Sat, 24 Aug 2019 12:38:56 +0000 (UTC)")
Message-ID: <k1b2-u2wa-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Aug 2019 13:08:42 -0000

Piotr Kubaj <pkubaj@FreeBSD.org> writes:

> Added: head/lang/angelscript/files/patch-as_config.h
> ==============================================================================
>
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/lang/angelscript/files/patch-as_config.h	Sat Aug 24 12:38:55 2019	(r509720)
> @@ -0,0 +1,12 @@
> +--- ../../source/as_config.h.orig	2019-07-28 15:58:25.283690000 +0200
> ++++ ../../source/as_config.h	2019-07-28 16:08:34.592212000 +0200
> +@@ -953,6 +953,9 @@
> + 			#define COMPLEX_RETURN_MASK (asOBJ_APP_CLASS_DESTRUCTOR | asOBJ_APP_CLASS_COPY_CONSTRUCTOR | asOBJ_APP_ARRAY)
> + 			#define THISCALL_PASS_OBJECT_POINTER_ON_THE_STACK
> + 			#define AS_X86
> ++		#elif defined(__powerpc64__)
> ++			#define AS_BIG_ENDIAN
> ++			#define AS_MAX_PORTABILITY

__powerpc64__ includes both big- and little- endian variants.
AS_BIG_ENDIAN is already defined conditionally in as_config.h:

  #if !defined(AS_BIG_ENDIAN) && \
          defined(__BYTE_ORDER) && __BYTE_ORDER == __BIG_ENDIAN || \
          defined(__BIG_ENDIAN__) || \
          defined(__ARMEB__) || \
          defined(__THUMBEB__) || \
          defined(__AARCH64EB__) || \
          defined(_MIBSEB) || defined(__MIBSEB) || defined(__MIBSEB__)
                  #define AS_BIG_ENDIAN
  #endif

$ clang -target powerpc64le-unknown-freebsd12.0 -dM -E -</dev/null | grep -i -e __p.\*pc -e endian
#define _LITTLE_ENDIAN 1
#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
#define __LITTLE_ENDIAN__ 1
#define __ORDER_BIG_ENDIAN__ 4321
#define __ORDER_LITTLE_ENDIAN__ 1234
#define __ORDER_PDP_ENDIAN__ 3412
#define __POWERPC__ 1
#define __PPC64__ 1
#define __PPC__ 1
#define __powerpc64__ 1
#define __powerpc__ 1
#define __ppc64__ 1
#define __ppc__ 1

$ clang -target powerpc64-unknown-freebsd12.0 -dM -E -</dev/null | fgrep -i endian
#define _BIG_ENDIAN 1
#define __BIG_ENDIAN__ 1
#define __BYTE_ORDER__ __ORDER_BIG_ENDIAN__
#define __ORDER_BIG_ENDIAN__ 4321
#define __ORDER_LITTLE_ENDIAN__ 1234
#define __ORDER_PDP_ENDIAN__ 3412

$ ssh ref12-ppc64.freebsd.org
$ gcc8 -dM -E -</dev/null | fgrep -i endian
#define __ORDER_LITTLE_ENDIAN__ 1234
#define __BIG_ENDIAN__ 1
#define __FLOAT_WORD_ORDER__ __ORDER_BIG_ENDIAN__
#define __ORDER_PDP_ENDIAN__ 3412
#define _BIG_ENDIAN 1
#define __ORDER_BIG_ENDIAN__ 4321
#define __VEC_ELEMENT_REG_ORDER__ __ORDER_BIG_ENDIAN__
#define __BYTE_ORDER__ __ORDER_BIG_ENDIAN__