From owner-svn-src-all@FreeBSD.ORG Wed Jul 22 03:50:55 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34167106566C; Wed, 22 Jul 2009 03:50:55 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 07A618FC12; Wed, 22 Jul 2009 03:50:55 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n6M3osrO030204; Wed, 22 Jul 2009 03:50:54 GMT (envelope-from cperciva@svn.freebsd.org) Received: (from cperciva@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n6M3osaj030202; Wed, 22 Jul 2009 03:50:54 GMT (envelope-from cperciva@svn.freebsd.org) Message-Id: <200907220350.n6M3osaj030202@svn.freebsd.org> From: Colin Percival Date: Wed, 22 Jul 2009 03:50:54 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r195817 - head/usr.sbin/sysinstall X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 03:50:55 -0000 Author: cperciva Date: Wed Jul 22 03:50:54 2009 New Revision: 195817 URL: http://svn.freebsd.org/changeset/base/195817 Log: Remove the "dedicated disk mode" partitioning option from sysinstall, in both the disk partitioning screen (the 'F' key) and via install.cfg (the VAR_DEDICATED_DISK option). This functionality is currently broken in 8.x due to libdisk and geom generating different partition names; this commit merely acts to help steer users away from the breakage. Submitted by: randi Approved by: re (kensmith) Modified: head/usr.sbin/sysinstall/disks.c Modified: head/usr.sbin/sysinstall/disks.c ============================================================================== --- head/usr.sbin/sysinstall/disks.c Wed Jul 22 01:07:49 2009 (r195816) +++ head/usr.sbin/sysinstall/disks.c Wed Jul 22 03:50:54 2009 (r195817) @@ -205,7 +205,7 @@ static void print_command_summary(void) { mvprintw(14, 0, "The following commands are supported (in upper or lower case):"); - mvprintw(16, 0, "A = Use Entire Disk G = set Drive Geometry C = Create Slice F = `DD' mode"); + mvprintw(16, 0, "A = Use Entire Disk G = set Drive Geometry C = Create Slice"); mvprintw(17, 0, "D = Delete Slice Z = Toggle Size Units S = Set Bootable | = Wizard m."); mvprintw(18, 0, "T = Change Type U = Undo All Changes Q = Finish"); if (!RunningAsInit) @@ -423,24 +423,10 @@ diskPartition(Device *dev) break; case 'A': - case 'F': /* Undocumented magic Dangerously Dedicated mode */ #if !defined(__i386__) && !defined(__amd64__) rv = 1; #else /* The rest is only relevant on x86 */ - cp = variable_get(VAR_DEDICATE_DISK); - if (cp && !strcasecmp(cp, "always")) - rv = 1; - else if (toupper(key) == 'A') - rv = 0; - else { - rv = msgYesNo("Do you want to do this with a true partition entry\n" - "so as to remain cooperative with any future possible\n" - "operating systems on the drive(s)?\n" - "(See also the section about ``dangerously dedicated''\n" - "disks in the FreeBSD FAQ.)"); - if (rv == -1) - rv = 0; - } + rv = 0; #endif All_FreeBSD(d, rv); variable_set2(DISK_PARTITIONED, "yes", 0);