From owner-cvs-src@FreeBSD.ORG Tue Jun 19 23:16:59 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5A5BF16A41F; Tue, 19 Jun 2007 23:16:59 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.freebsd.org (Postfix) with ESMTP id 2063513C44C; Tue, 19 Jun 2007 23:16:59 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.47] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id l5JNGtJS055472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Jun 2007 16:16:57 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <467863E0.2040906@FreeBSD.org> Date: Tue, 19 Jun 2007 16:16:48 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: Pav Lucistnik , Kris Kennaway References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> In-Reply-To: <200706182249.l5IMnE4H099470@repoman.freebsd.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2007 23:16:59 -0000 I have made the following patch to bring style(9) back and make code more readable. Do you guys want to run it on bento or could I just check it in? http://sobomax.homeunix.org/~sobomax/deps.c.diff -Maxim Pav Lucistnik wrote: > pav 2007-06-18 22:49:13 UTC > > FreeBSD src repository (doc,ports committer) > > Modified files: > usr.sbin/pkg_install/lib deps.c > Log: > - Replace rather inefficient bubble sort with a recursive depth-first search. > This speeds up registration of packages considerably. > - style(9) police welcome! > > PR: bin/112630 > Submitted by: Stephen Montgomery-Smith > Tested by: bento i386 experimental run > MFC after: 14 days > > Revision Changes Path > 1.12 +111 -65 src/usr.sbin/pkg_install/lib/deps.c > >