From owner-freebsd-pf@FreeBSD.ORG  Thu Jun  6 12:28:58 2013
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 45AA838E;
 Thu,  6 Jun 2013 12:28:58 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 by mx1.freebsd.org (Postfix) with ESMTP id 629C61E29;
 Thu,  6 Jun 2013 12:28:57 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.6/8.14.6) with ESMTP id r56CSuta046057;
 Thu, 6 Jun 2013 16:28:56 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.6/8.14.6/Submit) id r56CSuQL046056;
 Thu, 6 Jun 2013 16:28:56 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Thu, 6 Jun 2013 16:28:55 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Mikolaj Golub <trociny@FreeBSD.org>
Subject: Re: pf + vimage patch
Message-ID: <20130606122855.GC14667@glebius.int.ru>
References: <51AC84EE.6020009@gmx.com> <20130605085219.GA53217@gmail.com>
 <51B065F5.4080209@gmx.com> <20130606122409.GA10459@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20130606122409.GA10459@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-jail@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>,
 freebsd-virtualization@freebsd.org, freebsd-pf@freebsd.org
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jun 2013 12:28:58 -0000

On Thu, Jun 06, 2013 at 03:24:10PM +0300, Mikolaj Golub wrote:
M> > >> -VNET_DEFINE(u_long, pf_srchashsize);
M> > >> -#define	V_pf_srchashsize	VNET(pf_srchashsize)
M> > >> -SYSCTL_VNET_UINT(_net_pf, OID_AUTO, source_nodes_hashsize, CTLFLAG_RDTUN,
M> > >> -    &VNET_NAME(pf_srchashsize), 0, "Size of pf(4) source nodes hashtable");
M> > >> +u_long		pf_srchashsize;
M> > >> +SYSCTL_UINT(_net_pf, OID_AUTO, source_nodes_hashsize, CTLFLAG_RDTUN,
M> > >> +    &pf_srchashsize, 0, "Size of pf(4) source nodes hashtable");
M> > >>
M> > >
M> > > Why do you have to devirtualize these variables? Are per vnet
M> > > hashtables sizes not useful or do they cause issues?
M> > 
M> > Per VNET variables are not useful for pf_hashsize and pf_srchashsize
M> > since these values are RO and cannot be modified at runtime.
M> 
M> Indeed. I missed RDTUN flag.
M>  
M> > module unload is broken:( Maybe it can be fixed at a (bit) later date?
M> 
M> I don't think Gleb will be happy with this. Some time ago he removed
M> some vimage related stuff to prevent crashing on module unload (see
M> r229849). Actually your patch looks like a partial revert of that
M> commit. So I think you need to think about this issue from start. At
M> least it should not crash non-vimage kernel and there should be
M> understanding how to fix it for vimage kernel. Your approach with
M> keeping only one purge thread might make it simpler.

True. It is very much appreciated that you are working on vimage + pf,
but breaking module unload isn't an option.

When hacking on a part of kernel, having a possibility to avoid a reboot
after each compile is very important.

-- 
Totus tuus, Glebius.